Skip to content

Absorb c10d into the main cmake build#12953

Closed
anderspapitto wants to merge 1 commit intopytorch:masterfrom
anderspapitto:absorb-c10d
Closed

Absorb c10d into the main cmake build#12953
anderspapitto wants to merge 1 commit intopytorch:masterfrom
anderspapitto:absorb-c10d

Conversation

@anderspapitto
Copy link
Copy Markdown
Contributor

@anderspapitto anderspapitto commented Oct 22, 2018

No description provided.

Comment thread torch/lib/c10d/example/CMakeLists.txt Outdated

This comment was marked as off-topic.

@anderspapitto anderspapitto force-pushed the absorb-c10d branch 4 times, most recently from 708ea51 to 60b58e5 Compare October 24, 2018 20:43
@anderspapitto anderspapitto changed the title [WIP] Absorb c10d into the main cmake build Absorb c10d into the main cmake build Oct 24, 2018
Copy link
Copy Markdown
Collaborator

@soumith soumith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for the c10d commit

Comment thread torch/lib/THD/CMakeLists.txt Outdated

This comment was marked as off-topic.

Comment thread torch/lib/c10d/CMakeLists.txt Outdated

This comment was marked as off-topic.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anderspapitto is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@anderspapitto anderspapitto deleted the absorb-c10d branch October 25, 2018 05:46
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary: Pull Request resolved: pytorch#12953

Differential Revision: D10850274

Pulled By: anderspapitto

fbshipit-source-id: 42296e6e49ad8c1845040e031eab95ddbaf58ae4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants