link libgloo_cuda.a explictly from setup.py#12951
Closed
anderspapitto wants to merge 1 commit intopytorch:masterfrom
Closed
link libgloo_cuda.a explictly from setup.py#12951anderspapitto wants to merge 1 commit intopytorch:masterfrom
anderspapitto wants to merge 1 commit intopytorch:masterfrom
Conversation
soumith
reviewed
Oct 22, 2018
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ea9c880 to
9639740
Compare
anderspapitto
commented
Oct 23, 2018
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
9639740 to
2e9ce56
Compare
soumith
approved these changes
Oct 24, 2018
Collaborator
soumith
left a comment
There was a problem hiding this comment.
lgtm, remove bottom commit
2e9ce56 to
f64035d
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
anderspapitto is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
rather than pass a list through a text file
f64035d to
2dee022
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
anderspapitto is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: rather than pass a list through a text file Pull Request resolved: pytorch#12951 Differential Revision: D10528309 Pulled By: anderspapitto fbshipit-source-id: d94befcd61b6304815859694b623046f256462df
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rather than pass a list through a text file