Include c10 namespace into caffe2 and at namespaces.#12950
Closed
smessmer wants to merge 2 commits intoexport-D10518929from
Closed
Include c10 namespace into caffe2 and at namespaces.#12950smessmer wants to merge 2 commits intoexport-D10518929from
smessmer wants to merge 2 commits intoexport-D10518929from
Conversation
Differential Revision: D10496244 Differential Version: 61314115
ezyang
approved these changes
Oct 23, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
But you're going to need to fix the TensorList name conflict (it appears to be defined to be ArrayRef in at, but a IValue representing a mutable tensor list in torch)
Closed
Differential Revision: D10496244 Differential Version: 61463383
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#12950 For backwards compatibility, we want the c10 symbols to be reachable from caffe2 and aten. When we move classes from at/caffe2 to c10, this 1. allow keeping backwards compatibility with third paty code we can't control 2. allows splitting diffs that move such classes into two diffs, where one only fixes the includes and the second one fixes the namespaces. Reviewed By: ezyang Differential Revision: D10496244 fbshipit-source-id: 914818688fad8c079889dfdc6242bc228b539f0e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #13024 Fix TensorList ambiguity 💛
:black_circle: #12950 Include c10 namespace into caffe2 and at namespaces. 💚
For backwards compatibility, we want the c10 symbols to be reachable from caffe2 and aten.
When we move classes from at/caffe2 to c10, this
Differential Revision: D10496244