[C10D] Separate deviceKey from streamKey in getNCCLComm#129435
Closed
wconstab wants to merge 2 commits intogh/wconstab/313/basefrom
Closed
[C10D] Separate deviceKey from streamKey in getNCCLComm#129435wconstab wants to merge 2 commits intogh/wconstab/313/basefrom
wconstab wants to merge 2 commits intogh/wconstab/313/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129435
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6909683 with merge base failed to retrieve merge base, please contact dev infra: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The paves the way for a set of changes that would let us use the same
nccl communicator for collectives and p2p ops (and have that be eagerly
initialized instead of lazily initialized), but always use a dedicated
nccl stream for p2p operations with different ranks to ensure they can
overlap.
This PR only adds a new streamKey that defaults to the value of the
deviceKey, so should not affect runtime behavior at all.
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @d4l3k @c-p-i-o @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @penguinwu @tianyu-l @yf225 @chauhang