Use absolute path path.resolve() -> path.absolute()#129409
Use absolute path path.resolve() -> path.absolute()#129409XuehaiPan wants to merge 32 commits intogh/XuehaiPan/70/basefrom
path.resolve() -> path.absolute()#129409Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129409
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 01870ec with merge base e141cb9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
left a comment
There was a problem hiding this comment.
Small nit but SGTM once they're fixed
| "Union", | ||
| "defaultdict" | ||
| "defaultdict", | ||
| "Path" |
There was a problem hiding this comment.
Add new entries to this file is not ok. We should fix the callsite.
Given the particular folder, we can most likely just add a __all__ to the file.
There was a problem hiding this comment.
The torch.utils.data.datapipes.gen_pyi module does not intend to export anything. The __all__ list should be empty. Then we will have a longer public allow list in the json file if we set an empty __all__ list.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "need to revert to as dependency of #129374" -c nosignal |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@XuehaiPan your PR has been successfully reverted. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "Breaking internal CI, @albanD please help get this PR merged" -c ghfirst |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@XuehaiPan your PR has been successfully reverted. |
|
|
||
| sys.path.insert(0, str(REPO_ROOT)) | ||
|
|
||
| from tools.stats.import_test_stats import get_disabled_tests |
There was a problem hiding this comment.
Looks like internal failure on this line:
ModuleNotFoundError: No module named 'tools'
There was a problem hiding this comment.
I guess the path insert above doesn't work anymore.
cc @eellison why is this needed? We really shouldn't play with python path to find tests?
Stack from ghstack (oldest at bottom):
path.resolve()->path.absolute()#129409Changes:
.absolute():Path(__file__)->Path(__file__).absolute()path.resolve()withpath.absolute()if the code is resolving the PyTorch repo root directory.cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @peterbell10