[halide-backend] Disable split reductions for Halide#129320
Closed
jansel wants to merge 9 commits intogh/jansel/362/basefrom
Closed
[halide-backend] Disable split reductions for Halide#129320jansel wants to merge 9 commits intogh/jansel/362/basefrom
jansel wants to merge 9 commits intogh/jansel/362/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129320
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 514bafb with merge base 872d972 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 23, 2024
shunting314
approved these changes
Jun 24, 2024
eellison
approved these changes
Jun 24, 2024
This was referenced Jun 25, 2024
pytorchmergebot
added a commit
that referenced
this pull request
Jul 1, 2024
This reverts commit 9ae78a5. Reverted #129321 on behalf of https://github.com/jeanschmidt due to Reverting, as it is required to do so in order to revert #129320 ([comment](#129321 (comment)))
Contributor
|
@pytorchbot revert -m "This PR is breaking internal builds, please check comments on it D59204360" -c weird |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Jul 1, 2024
This reverts commit a18eb65. Reverted #129320 on behalf of https://github.com/jeanschmidt due to This PR is breaking internal builds, please check comments on it D59204360 ([comment](#129320 (comment)))
Collaborator
|
@jansel your PR has been successfully reverted. |
pytorchmergebot
added a commit
to khushi-411/pytorch
that referenced
this pull request
Jul 2, 2024
This reverts commit 9ae78a5. Reverted pytorch#129321 on behalf of https://github.com/jeanschmidt due to Reverting, as it is required to do so in order to revert pytorch#129320 ([comment](pytorch#129321 (comment)))
pytorchmergebot
added a commit
to khushi-411/pytorch
that referenced
this pull request
Jul 2, 2024
…#129320)" This reverts commit a18eb65. Reverted pytorch#129320 on behalf of https://github.com/jeanschmidt due to This PR is breaking internal builds, please check comments on it D59204360 ([comment](pytorch#129320 (comment)))
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
In theory Halide doesn't need the split reduction stuff we do for Triton since it can generate multiple kernels.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang