Use the newer one of cmake and cmake3.#12916
Closed
ssnl wants to merge 3 commits intopytorch:masterfrom
Closed
Conversation
soumith
approved these changes
Oct 21, 2018
Collaborator
|
please revert the large number of whitespace changes |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
SsnL has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
Looks good - thanks. |
Collaborator
Author
|
@pytorchbot retest this please |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
SsnL is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
This breaks for me on python2: |
Contributor
|
This fixes it for me: |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: On my devgpu, `cmake` is newer than `cmake3`. Using `cmake3` causes compilation to fail. Instead of blindly using `cmake3`, we pick the newer of the two. Pull Request resolved: pytorch#12916 Differential Revision: D10481922 Pulled By: SsnL fbshipit-source-id: 8340136c459e25da9f5fc4f420c7e67cadc28aff
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: A tweak to pytorch#12916 that only uses cmake3 when cmake isn't good enough. Hopefully fixes the issue zdevito saw. cc zdevito SsnL Pull Request resolved: pytorch#12972 Differential Revision: D10560674 Pulled By: orionr fbshipit-source-id: 90c71929630bb8167a3ee2cc6f306eefe5b85445
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my devgpu,
cmakeis newer thancmake3. Usingcmake3causes compilation to fail. Instead of blindly usingcmake3, we pick the newer of the two.