Use _th_ prefix instead of th_ prefix for Declarations.cwrap functions.#12889
Closed
gchanan wants to merge 2 commits intopytorch:masterfrom
Closed
Use _th_ prefix instead of th_ prefix for Declarations.cwrap functions.#12889gchanan wants to merge 2 commits intopytorch:masterfrom
gchanan wants to merge 2 commits intopytorch:masterfrom
Conversation
The plan here is that all functions in Declarations.cwrap will have a _th_ prefix and a native funciton that calls into the _th_ prefix version. Then, we check in the generated Declarations.cwrap equivalents and kill Declarations.cwrap and the corresponding codegen. This PR starts that process by moving some existing th_ prefixed functions to _th_.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@pytorchbt retest this please. |
Contributor
Author
|
@pytorchbot retest this please. |
ezyang
approved these changes
Oct 22, 2018
Contributor
|
CircleCI status for this PR: https://circleci.com/gh/pytorch/workflows/pytorch/tree/pull%2F12889 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 26, 2018
Summary: This is the same as #12889 with the addmm changes stripped out, since that appears to cause onnx broadcasting issues I don't understand. Pull Request resolved: #13128 Reviewed By: ezyang Differential Revision: D10853911 Pulled By: gchanan fbshipit-source-id: 08ec8629331972f0c332ccd036980fd9c87562b0
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 26, 2018
Summary: This is the same as pytorch/pytorch#12889 with the addmm changes stripped out, since that appears to cause onnx broadcasting issues I don't understand. Pull Request resolved: pytorch/pytorch#13128 Reviewed By: ezyang Differential Revision: D10853911 Pulled By: gchanan fbshipit-source-id: 08ec8629331972f0c332ccd036980fd9c87562b0
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
) Summary: This is the same as pytorch#12889 with the addmm changes stripped out, since that appears to cause onnx broadcasting issues I don't understand. Pull Request resolved: pytorch#13128 Reviewed By: ezyang Differential Revision: D10853911 Pulled By: gchanan fbshipit-source-id: 08ec8629331972f0c332ccd036980fd9c87562b0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plan here is that all functions in Declarations.cwrap will have a th prefix and a native funciton that calls into the th prefix version.
Then, we check in the generated Declarations.cwrap equivalents and kill Declarations.cwrap and the corresponding codegen.
This PR starts that process by moving some existing th_ prefixed functions to th.
Also kills th_tensor which isn't used anymore.