Add randn in onnx symbolic#12880
Add randn in onnx symbolic#12880zrphercule wants to merge 6 commits intopytorch:masterfrom zrphercule:fix_randn
Conversation
|
import to phabricator? |
|
@houseroad Let me take a look of the failing CI |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
You need to translate the attribute name, too:
https://github.com/onnx/onnx/blob/master/docs/Operators.md#RandomNormal
https://github.com/pytorch/pytorch/blob/master/caffe2/operators/filler_op.h#L405
Not exactly matching...
Also, no support for seed in Caffe2, we need to throw exception in such cases
|
@houseroad Yeah, I only took care of "shape" but forgot other attributes... |
|
@houseroad review? |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
houseroad
left a comment
There was a problem hiding this comment.
Also throw exceptions in python conversion code? Otherwise, LGTM.
|
@houseroad I have tested, and it seems even if there are extra attributes in nodes in python backend, it is okay. I will merge if once ci has been passed. |
|
Interesting, it's ok to merge it if CI passes. You can import first while waiting the CI. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
If failures are just time-out and caffe2_onnx_py2_gcc_ubuntu16_04_build/test are green, you probably can just land it |
|
@houseroad I believe so. Let's land it tomorrow morning!~ |
facebook-github-bot
left a comment
There was a problem hiding this comment.
zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: In this pr we added operator randn in onnx symbolic. Also, related tests are added. Pull Request resolved: pytorch#12880 Reviewed By: houseroad Differential Revision: D10501788 Pulled By: zrphercule fbshipit-source-id: ba8bb00ca848c4b95decabf638a1bc13fe11d03e
In this pr we added operator randn in onnx symbolic. Also, related tests are added.