Fix MSVC build for Python 3.6#12878
Closed
smessmer wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
Contributor
|
It's weird that our current Windows CI didn't catch this problem. @peterjc123 Do you have any insights? |
ezyang
approved these changes
Oct 19, 2018
Contributor
|
We are building with Python 3.7. Did 3.7 get rid of this macro? |
Collaborator
|
We did't set the Python version explicitly so it is actually building for Python 3.7. |
Summary: Pull Request resolved: pytorch#12878 Python 3.6 headers define their own ssize_t, which clashes with our definition. Luckily, they also define a `HAVE_SSIZE_T` macro we can use to check for this case. Reviewed By: ezyang Differential Revision: D10467239 fbshipit-source-id: bf9397f9fbbc10b6fb13c500b616c83c72480598
4cb6b30 to
88e7b87
Compare
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 23, 2018
Summary: Pull Request resolved: pytorch/pytorch#12878 Python 3.6 headers define their own ssize_t, which clashes with our definition. Luckily, they also define a `HAVE_SSIZE_T` macro we can use to check for this case. Reviewed By: ezyang Differential Revision: D10467239 fbshipit-source-id: 661675ad1e30a6ca26d6790eaa75657ef6bf37c2
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#12878 Python 3.6 headers define their own ssize_t, which clashes with our definition. Luckily, they also define a `HAVE_SSIZE_T` macro we can use to check for this case. Reviewed By: ezyang Differential Revision: D10467239 fbshipit-source-id: 661675ad1e30a6ca26d6790eaa75657ef6bf37c2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #12878 Fix MSVC build for Python 3.6 💚
Python 3.6 headers define their own ssize_t, which clashes with our definition.
Luckily, they also define a
HAVE_SSIZE_Tmacro we can use to check for this case.Differential Revision: D10467239