Add simple scripts for checking if generated code changed.#12835
Closed
gchanan wants to merge 3 commits intopytorch:masterfrom
Closed
Add simple scripts for checking if generated code changed.#12835gchanan wants to merge 3 commits intopytorch:masterfrom
gchanan wants to merge 3 commits intopytorch:masterfrom
Conversation
This is designed to make it easier to see how your codegen chagnes affected generated files. Limitations: This is NOT robust; if new directories are added that include generated files, they need to be added to tools/generated_dirs.txt. Note that subdirectories of the list are not included. This is particular to my workflow which I don't claim is generally applicable. Ideally we would have a script that pumped out a diff that could be attached to PRs. The process is for using these are: 1) python setup.py ... 2) tools/git_add_generated_dirs 3) Edit codegen 4) python setup.py ... 4) git diff to see changes 5) If satisfied: tools/git_reset_generated_dirs, commit, etc. If not satisfied: Go to 3)
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
I am happy to be told these are too specific for my workflow and we shouldn't bless it by putting this in the tree. My real hope is that someone takes this and makes it actually generally useful. |
ezyang
reviewed
Oct 18, 2018
| @@ -0,0 +1,2 @@ | |||
| BASEDIR=$(dirname "$0") | |||
| (< $BASEDIR/generated_dirs.txt xargs -i find {} -type f) | xargs git add -f | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
requested changes
Oct 18, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
The scripts themselves should have the docs you wrote in the commit.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
reviewed
Oct 22, 2018
| @@ -0,0 +1,13 @@ | |||
| #!/bin/sh | |||
|
|
|||
| # HOW TO USE: | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Oct 22, 2018
ezyang
approved these changes
Oct 22, 2018
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…2835) Summary: This is designed to make it easier to see how your codegen changes affected actual generated code. Limitations: A) This is NOT robust; if new directories are added that include generated files, they need to be added to tools/generated_dirs.txt. Note that subdirectories of the list are not included. B) This is particular to my workflow which I don't claim is generally applicable. Ideally we would have a script that pumped out a diff that could be attached to PRs. C) Only works on OSS and definitely won't work on windows. How to use: 1) python setup.py ... 2) tools/git_add_generated_dirs 3) Edit codegen 4) python setup.py ... 4) git diff to see changes 5) If satisfied: tools/git_reset_generated_dirs, commit, etc. If not satisfied: Go to 3) Pull Request resolved: pytorch#12835 Reviewed By: ezyang Differential Revision: D10452255 Pulled By: gchanan fbshipit-source-id: 294fc74d41d1b840c7a26d20e05efd0aff154635
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is designed to make it easier to see how your codegen changes affected actual generated code.
Limitations:
A) This is NOT robust; if new directories are added that include generated files, they need to be added to tools/generated_dirs.txt. Note that subdirectories of the list are not included.
B) This is particular to my workflow which I don't claim is generally applicable. Ideally we would have a script that pumped out a diff that could be attached to PRs.
C) Only works on OSS and definitely won't work on windows.
How to use:
If not satisfied: Go to 3)