Skip to content

Support scales as inputs in ResizeNearest#12720

Closed
houseroad wants to merge 6 commits intopytorch:masterfrom
houseroad:upsample_onnx
Closed

Support scales as inputs in ResizeNearest#12720
houseroad wants to merge 6 commits intopytorch:masterfrom
houseroad:upsample_onnx

Conversation

@houseroad
Copy link
Copy Markdown
Member

@houseroad houseroad commented Oct 16, 2018

To address onnx/onnx#1467

@houseroad houseroad requested a review from xiaomengy October 16, 2018 19:13
@houseroad
Copy link
Copy Markdown
Member Author

houseroad commented Oct 16, 2018

There will be another PR to adjust the pytorch ONNX exporter to support new version Upsample

xiaomengy
xiaomengy approved these changes Oct 16, 2018
View reviewed changes
Comment thread caffe2/operators/resize_op.cu Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Comment thread caffe2/operators/resize_op.cu Outdated

This comment was marked as off-topic.

Sign in to view

bddppq
bddppq reviewed Oct 16, 2018
View reviewed changes
Comment thread caffe2/operators/resize_op.cc Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

facebook-github-bot
facebook-github-bot reviewed Oct 16, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

d4l3k
d4l3k reviewed Oct 16, 2018
View reviewed changes
Comment thread caffe2/python/operator_test/resize_op_test.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

facebook-github-bot
facebook-github-bot reviewed Oct 16, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@d4l3k d4l3k mentioned this pull request Oct 16, 2018
Closed
facebook-github-bot
facebook-github-bot reviewed Oct 16, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@houseroad houseroad closed this Oct 17, 2018
@houseroad houseroad reopened this Oct 17, 2018
@houseroad houseroad closed this Oct 17, 2018
@houseroad houseroad reopened this Oct 17, 2018
facebook-github-bot
facebook-github-bot reviewed Oct 17, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

d4l3k added a commit to d4l3k/pytorch that referenced this pull request Oct 18, 2018
@d4l3k @facebook-github-bot
caffe2: UpsampleBilinear support for scales (pytorch#12736)
29950f3 
Summary:
Pull Request resolved: pytorch#12736

This updates UpsampleBilinearOp and UpsampleBilinearGradientOp to support scales to bring it inline with ResizeNearestOp pytorch#12720.

Reviewed By: houseroad

Differential Revision: D10416228

fbshipit-source-id: f687a16b238e81425a27a8d7037c4c3e602ed958
facebook-github-bot pushed a commit that referenced this pull request Oct 19, 2018
@d4l3k @facebook-github-bot
caffe2: UpsampleBilinear support for scales (#12736)
6190408 
Summary:
Pull Request resolved: #12736

This updates UpsampleBilinearOp and UpsampleBilinearGradientOp to support scales to bring it inline with ResizeNearestOp #12720.

Reviewed By: houseroad

Differential Revision: D10416228

fbshipit-source-id: f339b7e06979c9c566afb4cee64a2d939b352957
@ezyang ezyang added the merged label Jun 25, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@houseroad @facebook-github-bot
Support scales as inputs in ResizeNearest (pytorch#12720)
b977831 
Summary:
To address onnx/onnx#1467
Pull Request resolved: pytorch#12720

Reviewed By: BIT-silence

Differential Revision: D10414813

Pulled By: houseroad

fbshipit-source-id: 8831381b0115c363065c8d23bd1a95b4d641b857
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@d4l3k @facebook-github-bot
caffe2: UpsampleBilinear support for scales (pytorch#12736)
a92fe5a 
Summary:
Pull Request resolved: pytorch#12736

This updates UpsampleBilinearOp and UpsampleBilinearGradientOp to support scales to bring it inline with ResizeNearestOp pytorch#12720.

Reviewed By: houseroad

Differential Revision: D10416228

fbshipit-source-id: f339b7e06979c9c566afb4cee64a2d939b352957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4l3k d4l3k d4l3k left review comments

+3 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@bddppq bddppq bddppq left review comments

@xiaomengy xiaomengy xiaomengy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@houseroad @d4l3k @xiaomengy @facebook-github-bot @bddppq @ezyang