Skip to content

[c10d] Make c10d pickling/unpickling work#12694

Closed
teng-li wants to merge 4 commits intopytorch:masterfrom
teng-li:ddp_serialize
Closed

[c10d] Make c10d pickling/unpickling work#12694
teng-li wants to merge 4 commits intopytorch:masterfrom
teng-li:ddp_serialize

Conversation

@teng-li
Copy link
Copy Markdown
Contributor

@teng-li teng-li commented Oct 16, 2018

This fixes the issue for #12168

@teng-li teng-li requested review from apaszke and pietern October 16, 2018 01:56
@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented Oct 16, 2018

Needs a test. Does this conflict with #11705 ?

@teng-li
Copy link
Copy Markdown
Contributor Author

teng-li commented Oct 16, 2018

@ezyang It won't conflict, test added

@teng-li teng-li requested a review from ezyang October 16, 2018 05:45
@teng-li teng-li added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Oct 16, 2018
@teng-li
Copy link
Copy Markdown
Contributor Author

teng-li commented Oct 18, 2018

@ezyang stamp?

Copy link
Copy Markdown
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't closely check the distributed code, but test changes LGTM.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teng-li is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ezyang ezyang added the merged label Jun 25, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
This fixes the issue for pytorch#12168
Pull Request resolved: pytorch#12694

Differential Revision: D10468717

Pulled By: teng-li

fbshipit-source-id: 3df31d75eea19d6085af665f5350d3cb667a5048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants