Fix binary_cross_entropy_with_logits#12624
Closed
seayoung1112 wants to merge 1 commit intopytorch:masterfrom
Closed
Fix binary_cross_entropy_with_logits#12624seayoung1112 wants to merge 1 commit intopytorch:masterfrom
seayoung1112 wants to merge 1 commit intopytorch:masterfrom
Conversation
ssnl
reviewed
Oct 13, 2018
Collaborator
ssnl
left a comment
There was a problem hiding this comment.
- Could you instead use the pattern used in other places, and replace
legacy_get_stringwithlegacy_get_enum? - Need some tests
cc @ailzhang this may be why you get different numbers.. It is sooooo bad that our argparser accepted string reduction!
Contributor
Author
|
@ssnl can we do it in another diff? I'm doing this as a fastest way to unblock our training pipeline from this bug |
Collaborator
|
@seayoung1112 we should add quick tests in test_nn.py. After that this can be shipped, and you can follow-up on (1) in a later diff. |
Collaborator
|
(1) is just a 1-line change and is shorter than your current fix though... |
Summary: binary_cross_entropy_with_logits is broken when redcue is not None Differential Revision: D10372032 fbshipit-source-id: 30a9b21623fa2e67f554aa5b587aa285322d2456
1b2d1fb to
ecf796a
Compare
Contributor
|
test is broken. Give it a different name. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Fix pytorch#12624 . internal usecase of legacy `reduce`. Add test in test_nn Pull Request resolved: pytorch#12689 Reviewed By: ezyang Differential Revision: D10391195 Pulled By: ailzhang fbshipit-source-id: 1af2b258c4abb2b6527eaaeac63e8bf1762c66a1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: binary_cross_entropy_with_logits is broken when redcue is not None
Differential Revision: D10372032