Improve reporting on pytest.#12610
Closed
ezyang wants to merge 2 commits intopytorch:masterfrom
Closed
Conversation
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
Author
|
Here's what it looks like after: Not perfect (there's still the onnx coverage report; see onnx/onnx#1506 ) but there are no more warnings. That's very nice. |
Contributor
|
Is blindly suppressing them the right thing to do? Are they meaningful? |
smessmer
approved these changes
Oct 15, 2018
Contributor
Author
|
Right now, most of the warnings are coming from onnx. In principle, it might be useful to squash these warnings, but this only makes sense if you're also wiling to Werror on them. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Before and after coming after I run the tests on CI Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch#12610 Differential Revision: D10419483 Pulled By: ezyang fbshipit-source-id: 5543e971f8362e4cea64f332ba44a26c2145caea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before and after coming after I run the tests on CI
Signed-off-by: Edward Z. Yang ezyang@fb.com