Add userbase library dir to windows dll search path#125684
Closed
atalman wants to merge 3 commits intopytorch:mainfrom
Closed
Add userbase library dir to windows dll search path#125684atalman wants to merge 3 commits intopytorch:mainfrom
atalman wants to merge 3 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125684
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 202f154 with merge base 8573d95 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
reviewed
May 7, 2024
torch/__init__.py
Outdated
| pfiles_path = os.getenv('ProgramFiles', 'C:\\Program Files') | ||
| py_dll_path = os.path.join(sys.exec_prefix, 'Library', 'bin') | ||
| th_dll_path = os.path.join(os.path.dirname(__file__), 'lib') | ||
| appdata_dll_path = os.path.join(os.getenv('APPDATA'), 'Python', 'Library', 'bin') |
Contributor
There was a problem hiding this comment.
This should be one of the sysconfig flavors, let me try to find out which one...
malfet
reviewed
May 7, 2024
malfet
approved these changes
May 7, 2024
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
Author
|
@pytorchbot cherry-pick --onto release/2.3 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
May 13, 2024
Fixes #125109 which is a regression introduced by pytorch/builder#1467 that adds dynamic dependency to mkl, which if installed in the user-dir is placed into `sysconfig.sysconfig.get_config_var("userbase") / "Library" / "bin"` Fix this one, but adding `userbase` folder to the DLL search path Testing before this fix: ``` Python 3.12.3 (tags/v3.12.3:f6650f9, Apr 9 2024, 14:05:25) [MSC v.1938 64 bit (AMD64)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import torch Traceback (most recent call last): File "<stdin>", line 1, in <module> File "C:\Users\Administrator\AppData\Roaming\Python\Python312\site-packages\torch\__init__.py", line 141, in <module> raise err OSError: [WinError 126] The specified module could not be found. Error loading "C:\Users\Administrator\AppData\Roaming\Python\Python312\site-packages\torch\lib\shm.dll" or one of its dependencies. >>> exit() ``` After: ``` c:\Program Files\Python312>python Python 3.12.3 (tags/v3.12.3:f6650f9, Apr 9 2024, 14:05:25) [MSC v.1938 64 bit (AMD64)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import torch >>> exit() ``` Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com> Pull Request resolved: #125684 Approved by: https://github.com/malfet (cherry picked from commit fdfef75)
Collaborator
Cherry picking #125684The cherry pick PR is at #126095 and it is recommended to link a critical cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
huydhn
pushed a commit
that referenced
this pull request
May 13, 2024
Add userbase library dir to windows dll search path (#125684) Fixes #125109 which is a regression introduced by pytorch/builder#1467 that adds dynamic dependency to mkl, which if installed in the user-dir is placed into `sysconfig.sysconfig.get_config_var("userbase") / "Library" / "bin"` Fix this one, but adding `userbase` folder to the DLL search path Testing before this fix: ``` Python 3.12.3 (tags/v3.12.3:f6650f9, Apr 9 2024, 14:05:25) [MSC v.1938 64 bit (AMD64)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import torch Traceback (most recent call last): File "<stdin>", line 1, in <module> File "C:\Users\Administrator\AppData\Roaming\Python\Python312\site-packages\torch\__init__.py", line 141, in <module> raise err OSError: [WinError 126] The specified module could not be found. Error loading "C:\Users\Administrator\AppData\Roaming\Python\Python312\site-packages\torch\lib\shm.dll" or one of its dependencies. >>> exit() ``` After: ``` c:\Program Files\Python312>python Python 3.12.3 (tags/v3.12.3:f6650f9, Apr 9 2024, 14:05:25) [MSC v.1938 64 bit (AMD64)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import torch >>> exit() ``` Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com> Pull Request resolved: #125684 Approved by: https://github.com/malfet (cherry picked from commit fdfef75) Co-authored-by: atalman <atalman@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125109 which is a regression introduced by pytorch/builder#1467 that adds dynamic dependency to mkl, which if installed in the user-dir is placed into
sysconfig.sysconfig.get_config_var("userbase") / "Library" / "bin"Fix this one, but adding
userbasefolder to the DLL search pathTesting before this fix:
After: