Closed
Conversation
By calling `realPartOfTensor:` if input type is abs
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125662
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit bb3405f with merge base f35fe4e ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot merge -f "MPS tests and lint are green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
|
@pytorchbot cherry-pick --onto release/2.3 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
May 13, 2024
By calling `realPartOfTensor:` if input type is complex on Sonoma and fall back to `at::view_as_real` trick on Ventura. Split `unary_op` template into `unary_op` and `unary_op_noresize`, which skips resize and empty checks Marked `abs`, `isclose` and `nn.functional.softsign` OpInfo tests as supported by complex types Fixes #125135 Pull Request resolved: #125662 Approved by: https://github.com/kulinseth (cherry picked from commit 0fd1fc1)
Collaborator
Cherry picking #125662The cherry pick PR is at #126096 and it is recommended to link a critical cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
huydhn
pushed a commit
that referenced
this pull request
May 13, 2024
[MPS] Fix `abs` for complex types (#125662) By calling `realPartOfTensor:` if input type is complex on Sonoma and fall back to `at::view_as_real` trick on Ventura. Split `unary_op` template into `unary_op` and `unary_op_noresize`, which skips resize and empty checks Marked `abs`, `isclose` and `nn.functional.softsign` OpInfo tests as supported by complex types Fixes #125135 Pull Request resolved: #125662 Approved by: https://github.com/kulinseth (cherry picked from commit 0fd1fc1) Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By calling
realPartOfTensor:if input type is complex on Sonoma and fall back toat::view_as_realtrick on Ventura.Split
unary_optemplate intounary_opandunary_op_noresize, which skips resize and empty checksMarked
abs,iscloseandnn.functional.softsignOpInfo tests as supported by complex typesFixes #125135