[noland] remove __TypeName() from typeid#12479
Closed
smessmer wants to merge 1 commit intoexport-D10229684from
Closed
[noland] remove __TypeName() from typeid#12479smessmer wants to merge 1 commit intoexport-D10229684from
smessmer wants to merge 1 commit intoexport-D10229684from
Conversation
Differential Revision: D10255651 Differential Version: 60108180
This was referenced Oct 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #12412 [noland] try if global variable on msvc works with CAFFE2_API 💛
:black_circle: #12479 [noland] remove __TypeName() from typeid 💛
:white_circle: #12481 [noland] Remove TypeIdentifier::Get() 💛
Not meant for landing, will be published as another diff if it works.
Differential Revision: D10255651