[dynamo] Refactor into torch/_inductor/runtime/compile_tasks.py by jansel · Pull Request #124681 · pytorch/pytorch

jansel · 2024-04-22T23:47:44Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

Differential Revision: D56723769

[ghstack-poisoned]

pytorch-bot · 2024-04-22T23:47:47Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124681

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 701be7d with merge base 26f8d96 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

masnesral · 2024-04-23T00:17:18Z

torch/_inductor/runtime/compile_tasks.py

+    if codecache:
+        return codecache.PyCodeCache.load_by_key_path(key, path)
+    else:
+        return _reload_python_module(key, path)


Nit: AFAICT, this PR is mostly just moving methods around. This is the one place I don't quite grok. What's happening that requires the sys.modules.get? So a comment about what's going on here would be nice.

It is so that in the next PR when we do:

sys.modules["torch"] = MockTorch()

we don't try to go via codecache.

masnesral

One nit, but LGTM

jansel · 2024-04-23T00:21:24Z

@pytorchbot merge

pytorchmergebot · 2024-04-23T00:23:13Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-04-23T06:21:49Z

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

jansel · 2024-04-23T17:49:31Z

@pytorchbot merge

pytorchmergebot · 2024-04-23T17:51:10Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

jeanschmidt · 2024-04-25T11:11:52Z

@pytorchbot revert -m "breaking internal tests, check D56522594 -c nosignal

pytorch-bot · 2024-04-25T11:11:53Z

❌ 🤖 pytorchbot command failed:

Got EOF while in a quoted string```
Try `@pytorchbot --help` for more info.

jeanschmidt · 2024-04-25T11:12:16Z

@pytorchbot revert -m "breaking internal tests, check D56522594" -c nosignal

pytorchmergebot · 2024-04-25T11:13:53Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2024-04-25T11:14:06Z

@jansel your PR has been successfully reverted.

…py (#124681)" This reverts commit 0792cea. Reverted #124681 on behalf of https://github.com/jeanschmidt due to breaking internal tests, check D56522594 ([comment](#124681 (comment)))

…py (pytorch#124681)" This reverts commit 0792cea. Reverted pytorch#124681 on behalf of https://github.com/jeanschmidt due to breaking internal tests, check D56522594 ([comment](pytorch#124681 (comment)))

…ks.py" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

masnesral · 2024-04-29T20:49:08Z

@masnesral has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…or/runtime/compile_tasks.py" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang Differential Revision: [D56723769](https://our.internmc.facebook.com/intern/diff/D56723769) [ghstack-poisoned]

ghstack-source-id: f32c461 Pull Request resolved: #124681

masnesral · 2024-04-30T00:35:16Z

@masnesral has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

masnesral · 2024-04-30T16:52:10Z

@pytorchbot merge

pytorchmergebot · 2024-04-30T16:53:58Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…rch#124681) Pull Request resolved: pytorch#124681 Approved by: https://github.com/masnesral ghstack dependencies: pytorch#124592

…py (pytorch#124681)" This reverts commit 0792cea. Reverted pytorch#124681 on behalf of https://github.com/jeanschmidt due to breaking internal tests, check D56522594 ([comment](pytorch#124681 (comment)))

) Differential Revision: [D56723769](https://our.internmc.facebook.com/intern/diff/D56723769) Co-authored-by: Sam Larsen <slarsen@meta.com> Pull Request resolved: #124681 Approved by: https://github.com/masnesral ghstack dependencies: #124592

Update

7251e0f

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: inductor labels Apr 22, 2024

This was referenced Apr 22, 2024

[inductor] Remove usage of device_interface from _inductor.runtime #124592

Closed

[inductor] Add thread+subproc-based worker_start_method #124682

Closed

[inductor] Add ProcessPool-in-subproc worker_start_method #122941

Closed

jansel requested a review from masnesral April 22, 2024 23:51

jansel added the topic: not user facing topic category label Apr 22, 2024

Update

70b6934

[ghstack-poisoned]

jansel added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 23, 2024

masnesral reviewed Apr 23, 2024

View reviewed changes

masnesral approved these changes Apr 23, 2024

View reviewed changes

pytorchmergebot added the merging label Apr 23, 2024

pytorchmergebot added the Merged label Apr 23, 2024

pytorchmergebot closed this in 0792cea Apr 23, 2024

pytorchmergebot removed the merging label Apr 23, 2024

pytorchmergebot added the Reverted label Apr 25, 2024

pytorchmergebot reopened this Apr 25, 2024

masnesral added a commit that referenced this pull request Apr 29, 2024

[dynamo] Refactor into torch/_inductor/runtime/compile_tasks.py

4ac9df3

ghstack-source-id: f32c461 Pull Request resolved: #124681

pytorchmergebot added the merging label Apr 30, 2024

pytorchmergebot closed this in d699ade Apr 30, 2024

pytorchmergebot removed the merging label Apr 30, 2024

github-actions bot deleted the gh/jansel/329/head branch June 4, 2024 01:58

Conversation

jansel commented Apr 22, 2024 • edited by masnesral Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124681

✅ No Failures

Uh oh!

masnesral Apr 23, 2024

Choose a reason for hiding this comment

Uh oh!

jansel Apr 23, 2024

Choose a reason for hiding this comment

Uh oh!

masnesral left a comment

Choose a reason for hiding this comment

Uh oh!

jansel commented Apr 23, 2024

Uh oh!

pytorchmergebot commented Apr 23, 2024

Merge started

Uh oh!

pytorchmergebot commented Apr 23, 2024

Uh oh!

jansel commented Apr 23, 2024

Uh oh!

pytorchmergebot commented Apr 23, 2024

Merge started

Uh oh!

jeanschmidt commented Apr 25, 2024

Uh oh!

pytorch-bot bot commented Apr 25, 2024

Uh oh!

jeanschmidt commented Apr 25, 2024

Uh oh!

pytorchmergebot commented Apr 25, 2024

Uh oh!

pytorchmergebot commented Apr 25, 2024

Uh oh!

masnesral commented Apr 29, 2024

Uh oh!

masnesral commented Apr 30, 2024

Uh oh!

masnesral commented Apr 30, 2024

Uh oh!

pytorchmergebot commented Apr 30, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jansel commented Apr 22, 2024 •

edited by masnesral

Loading

pytorch-bot bot commented Apr 22, 2024 •

edited

Loading