[RESUBMIT] Remove some Type.tensor usages and remove native_tensor without size.#12403
Closed
gchanan wants to merge 2 commits intopytorch:masterfrom
Closed
[RESUBMIT] Remove some Type.tensor usages and remove native_tensor without size.#12403gchanan wants to merge 2 commits intopytorch:masterfrom
gchanan wants to merge 2 commits intopytorch:masterfrom
Conversation
…pytorch#12355) Summary: This is to move us along the path to removing Type from the public API. Pull Request resolved: pytorch#12355 Reviewed By: ezyang Differential Revision: D10212616 Pulled By: gchanan fbshipit-source-id: c9cd128d1111ab219cb0b2f3bf5b632502ab97c0
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Oct 6, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 6, 2018
… (#12403) Summary: Same as before, but with "initialTensorOptions()" instead of "TensorOptions(false)". Pull Request resolved: pytorch/pytorch#12403 Differential Revision: D10225427 Pulled By: gchanan fbshipit-source-id: 60bd025a5cc15bdbbab6eafc91ea55f5f2c3117e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as before, but with "initialTensorOptions()" instead of "TensorOptions(false)".