Allow module.forward() to return a dict#1239
Closed
dnouri wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
Useful to be able to name variables you return in case there is a few of them. Also a plus for maintainablity; that is, you can add variables later without breaking every caller's code.
afb26a4 to
4960683
Compare
Author
Author
|
Looks like we actually want to support list-of-lists as return values. Closing as duplicate. |
jjsjann123
pushed a commit
to jjsjann123/pytorch
that referenced
this pull request
Nov 5, 2021
Project persistent buffers integration (pytorch#1238) Add warp padding to normalization and reduction schedulers (pytorch#1239) Aggressively go after 3D scheduling in normalization and reductions. (pytorch#1240) Fix sorting for reduction schedulers... again. (pytorch#1241)
hubertlu-tw
pushed a commit
to hubertlu-tw/pytorch
that referenced
this pull request
Nov 1, 2022
* pass `self.mask_additive` * clang-format * removing THCState
hubertlu-tw
pushed a commit
to hubertlu-tw/pytorch
that referenced
this pull request
Nov 1, 2022
* pass `self.mask_additive` * clang-format * removing THCState
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful to be able to name variables you return in case there is a few
of them. Also a plus for maintainablity; that is, you can add
variables later without breaking every caller's code.