restore caffe2 strides#12381
Closed
li-roy wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
975eac8 to
432abad
Compare
432abad to
1c96aa3
Compare
ezyang
approved these changes
Oct 8, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
That beautiful moment when you realize that it's easy :)
P.S., a note for the future: the threading fix should be put into a separate patch, to ease bisecters from the future (if the ordering there was actually important). For now, mentioning it in the commit message should be good enough.
Contributor
Author
|
@pytorchbot retest this please |
1c96aa3 to
d6d4341
Compare
Summary: Pull Request resolved: pytorch#12381 The workflow passes after D10150834, so we can restore strides. Reviewed By: ezyang Differential Revision: D10220313 fbshipit-source-id: 9b943b82a5fec1717af60f4b17fa52eef0be36bd
d6d4341 to
fd0a873
Compare
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 16, 2018
Summary: Pull Request resolved: pytorch/pytorch#12381 The workflow passes after D10150834, so we can restore strides. Reviewed By: ezyang Differential Revision: D10220313 fbshipit-source-id: aaf9edebf4ff739cbe45b2d32e77918fce47ba34
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#12381 The workflow passes after D10150834, so we can restore strides. Reviewed By: ezyang Differential Revision: D10220313 fbshipit-source-id: aaf9edebf4ff739cbe45b2d32e77918fce47ba34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The workflow passes after D10150834, so we can restore strides.
Differential Revision: D10220313