Closed
Conversation
Summary: `long` and `int64_t` are the same type on 64-bit Android. Differential Revision: D10204892 fbshipit-source-id: 2e58a0a852fd013c984d150ea04f7363763206cf
Contributor
|
Remaining build failure from CI seems to be related to nccl - thanks so much for the fix! |
Yangqing
approved these changes
Oct 4, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 4, 2018
Summary: Pull Request resolved: pytorch/pytorch#12340 `long` and `int64_t` are the same type on 64-bit Android. Reviewed By: Yangqing Differential Revision: D10204892 fbshipit-source-id: 2d5bf707bf87b99fc597c9292b59f032e9004620
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
longandint64_tare the same type on 64-bit Android.Differential Revision: D10204892