[Build] Use open-source NCCL2 in PyTorch#12312
[Build] Use open-source NCCL2 in PyTorch#12312teng-li wants to merge 2 commits intopytorch:masterfrom
Conversation
facebook-github-bot
left a comment
There was a problem hiding this comment.
teng-li has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
OOC why is it doubly nested in nccl/nccl? |
orionr
left a comment
There was a problem hiding this comment.
My only question is whether we can get everything into the NCCL submodule repository (CMakeLists.txt and .gitignore it looks like). If so, it would make this easier. Note that adding submodules when bringing into fbcode is somewhat of a pain, so let's go through that together. Let's make 100% sure we want the submodule at third_party/nccl/nccl before we work on that, but approving to unblock.
|
|
||
| ADD_CUSTOM_COMMAND( | ||
| WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} | ||
| WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/nccl |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Summary: - Removed the old nccl file - Make open-source NCCL a submodule - CMake to make NCCL itself NCCL2 now is in the default build. Pull Request resolved: pytorch/pytorch#12312 Differential Revision: D10190845 Pulled By: teng-li fbshipit-source-id: 08d42253b774149a66919d194f88b34628c39bae
NCCL2 now is in the default build.