Closed
Conversation
ezyang
reviewed
Oct 3, 2018
aten/src/ATen/core/Device.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
5ca896b to
0b7c84f
Compare
0b7c84f to
c45430a
Compare
ezyang
approved these changes
Oct 3, 2018
goldsborough
suggested changes
Oct 3, 2018
Contributor
goldsborough
left a comment
There was a problem hiding this comment.
Sorry but I think this could be better
c45430a to
bcf3174
Compare
bcf3174 to
22dc4df
Compare
22dc4df to
36d0be0
Compare
36d0be0 to
89da20b
Compare
89da20b to
971d924
Compare
971d924 to
6639e1f
Compare
6639e1f to
8e72719
Compare
8e72719 to
2715f1c
Compare
2715f1c to
359771b
Compare
ezyang
reviewed
Oct 4, 2018
aten/src/ATen/core/Device.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
359771b to
d420be0
Compare
d420be0 to
3832ede
Compare
Contributor
|
For the record: I am OK with landing either the old code, or the new code, once its build failures are fixed. |
3832ede to
012c05c
Compare
Summary: Pull Request resolved: pytorch#12293 Adding support for additional device types besides cuda and cpu. Reviewed By: ezyang Differential Revision: D10175683 fbshipit-source-id: 0b9c7ee9285b762fb268fed439ab2c9f7d37c3c5
012c05c to
849bba4
Compare
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 5, 2018
Summary: Pull Request resolved: pytorch/pytorch#12293 Adding support for additional device types besides cuda and cpu. Reviewed By: ezyang Differential Revision: D10175683 fbshipit-source-id: 7a8a35c3f1b13a3b6ed84dd2d835f3902a418a6c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Adding support for additional device types besides cuda and cpu.
Differential Revision: D10175683