pyHipify Fixes#12292
Closed
rohithkrn wants to merge 4 commits intopytorch:masterfrom
rohithkrn:pyhipify_fixes
Closed
pyHipify Fixes#12292rohithkrn wants to merge 4 commits intopytorch:masterfrom rohithkrn:pyhipify_fixes
rohithkrn wants to merge 4 commits intopytorch:masterfrom
rohithkrn:pyhipify_fixes
Conversation
Contributor
|
thanks @rohithkrn |
bddppq
reviewed
Oct 3, 2018
| ("std::remainder", ("::remainder")), | ||
| ] | ||
|
|
||
| MATH_TRANSPILATIONS = collections.OrderedDict(MATH_TRANSPILATIONS) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 4, 2018
Summary: This PR makes the following changes: * stores cuda_to_hip mappings in python OrderedDicts * Replace cudaError with cudaError_t and remove cudaError mapping bddppq petrex Pull Request resolved: pytorch/pytorch#12292 Differential Revision: D10184399 Pulled By: bddppq fbshipit-source-id: b20a4661ba534e4fb12aa738e1ed74dba84f30fc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
@bddppq @petrex