Reduce size of TensorImpl from 160 bytes to 128 bytes#12266
Closed
Reduce size of TensorImpl from 160 bytes to 128 bytes#12266
Conversation
Differential Revision: D10150834 Differential Version: 59477747
Differential Revision: D10150834 Differential Version: 59479009
Differential Revision: D10150834 Differential Version: 59481546
Differential Revision: D10150834 Differential Version: 59484820
Differential Revision: D10150834 Differential Version: 59493561
Contributor
Author
|
@pytorchbot retest this please |
apaszke
reviewed
Oct 3, 2018
| at::Storage storage_; // TODO: Fix visibility on me | ||
|
|
||
| protected: | ||
| std::vector<int64_t> sizes_; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 3, 2018
Summary: Pull Request resolved: pytorch/pytorch#12266 - Put all byte-size fields together (booleans and TensorTypeId), so they can be coalesced into a single word. - Replace std::vector<int64_t> strides with std::unique_ptr<int64_t[]>, saving two words. Reviewed By: dzhulgakov Differential Revision: D10150834 fbshipit-source-id: f54f38eec34732f3ff7e52e00b1371d7b5b210eb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #12266 Reduce size of TensorImpl from 160 bytes to 128 bytes 💛
so they can be coalesced into a single word.
std::unique_ptr<int64_t[]>, saving two words.
Differential Revision: D10150834