Skip to content

update docs for sparse tensor#12221

Closed
weiyangfb wants to merge 3 commits intopytorch:masterfrom
weiyangfb:update_doc_example_sparse_tensor
Closed

update docs for sparse tensor#12221
weiyangfb wants to merge 3 commits intopytorch:masterfrom
weiyangfb:update_doc_example_sparse_tensor

Conversation

@weiyangfb
Copy link
Copy Markdown
Contributor

@weiyangfb weiyangfb commented Oct 1, 2018

  • update docs examples at sparse tensor after print format changed
  • update example to create empty sparse tensor:
>>> torch.sparse_coo_tensor(torch.LongTensor(size=[1,0]), [], torch.Size([1]))
tensor(indices=tensor([], size=(1, 0)),
       values=tensor([], size=(0,)),
       size=(1,), nnz=0, layout=torch.sparse_coo)

@zou3519 @ssnl @yf225

@ssnl ssnl self-assigned this Oct 8, 2018
ssnl
ssnl approved these changes Oct 8, 2018
View reviewed changes
Comment thread torch/_torch_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Comment thread torch/_torch_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ssnl
ssnl requested changes Oct 8, 2018
View reviewed changes
Comment thread torch/_torch_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

Comment thread torch/_torch_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

Comment thread torch/_torch_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

@weiyangfb weiyangfb force-pushed the update_doc_example_sparse_tensor branch 2 times, most recently from 5b6a01c to fdd8051 Compare October 9, 2018 01:33
@weiyangfb
Copy link
Copy Markdown
Contributor Author

weiyangfb commented Oct 15, 2018

@ssnl is this ready to go?

ssnl
ssnl reviewed Oct 15, 2018
View reviewed changes
Comment thread torch/_torch_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

Comment thread torch/_torch_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

Comment thread torch/_torch_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

@weiyangfb weiyangfb force-pushed the update_doc_example_sparse_tensor branch from fdd8051 to 8df03ad Compare October 16, 2018 02:59
facebook-github-bot
facebook-github-bot reviewed Oct 16, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weiyangfb is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Oct 16, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weiyangfb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@weiyangfb weiyangfb mentioned this pull request Oct 16, 2018
Closed
@ezyang ezyang added the merged label Jun 26, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@weiyangfb @facebook-github-bot
update docs for sparse tensor (pytorch#12221)
4b76f0d 
Summary:
- update docs examples at sparse tensor after print format changed
- update example to create empty sparse tensor:
```
>>> torch.sparse_coo_tensor(torch.LongTensor(size=[1,0]), [], torch.Size([1]))
tensor(indices=tensor([], size=(1, 0)),
       values=tensor([], size=(0,)),
       size=(1,), nnz=0, layout=torch.sparse_coo)
```

zou3519 SsnL yf225
Pull Request resolved: pytorch#12221

Differential Revision: D10412447

Pulled By: weiyangfb

fbshipit-source-id: 155b8cb0965f060e978f12239abdc1b3b41f6ab0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssnl ssnl ssnl approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@ezyang ezyang Awaiting requested review from ezyang

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

@zdevito zdevito Awaiting requested review from zdevito

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ssnl ssnl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@weiyangfb @ssnl @facebook-github-bot @ezyang