Fix build error mkldnn due to corruptted CMAKE_REQUIRED_LIBRARIES#12195
Closed
Jianhui-Li wants to merge 1 commit intopytorch:masterfrom
Closed
Fix build error mkldnn due to corruptted CMAKE_REQUIRED_LIBRARIES#12195Jianhui-Li wants to merge 1 commit intopytorch:masterfrom
Jianhui-Li wants to merge 1 commit intopytorch:masterfrom
Conversation
Signed-off-by: Gu, Jinghui <jinghui.gu@intel.com>
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@gujinghui Could you describe how to reproduce the error you saw? @orionr Does this look good to you? |
orionr
approved these changes
Oct 3, 2018
Contributor
There was a problem hiding this comment.
Thank you for this! Looks good. Also seems like this has already been fixed in the upstream location (I didn't check everything, but a spot check seemed to match) at https://github.com/Kitware/CMake/blob/master/Modules/FindBLAS.cmake and https://github.com/Kitware/CMake/blob/master/Modules/FindLAPACK.cmake
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 4, 2018
…2195) Summary: This is to fix cmake-time compilation error. When we change script to build Caffe2 with mkldnn, we run into some cmake-time compilation support check (like in libsleef) failed due to incorrect setting of CMAKE_REQUIRED_LIBRARIES. It is a global setting which can interfere camke compilation if it is not clean up properly. FindBLAS.cmake and FindLAPACK.cmake didn't clean this flag, and causes incorrect building of libsleef.so. yinghai gujinghui Pull Request resolved: pytorch/pytorch#12195 Differential Revision: D10159314 Pulled By: yinghai fbshipit-source-id: 04908738f7d005579605b9c2a58d54f035d3baf4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix cmake-time compilation error.
When we change script to build Caffe2 with mkldnn, we run into some cmake-time compilation support check (like in libsleef) failed due to incorrect setting of CMAKE_REQUIRED_LIBRARIES. It is a global setting which can interfere camke compilation if it is not clean up properly. FindBLAS.cmake and FindLAPACK.cmake didn't clean this flag, and causes incorrect building of libsleef.so.
@yinghai @gujinghui