Skip to content

dense.to_sparse() re: #8853#12171

Closed
realdoug wants to merge 1 commit intopytorch:masterfrom
realdoug:dense2sparse
Closed

dense.to_sparse() re: #8853#12171
realdoug wants to merge 1 commit intopytorch:masterfrom
realdoug:dense2sparse

Conversation

@realdoug
Copy link
Contributor

@realdoug realdoug commented Sep 28, 2018

Here is my stab at dense.to_sparse

ssnl
ssnl reviewed Sep 28, 2018
View reviewed changes
torch/_tensor_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

vishwakftw
vishwakftw reviewed Sep 28, 2018
View reviewed changes
torch/_tensor_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@realdoug realdoug requested a review from zou3519 as a code owner October 1, 2018 03:42
@realdoug realdoug mentioned this pull request Oct 3, 2018
Open
14 tasks
weiyangfb
weiyangfb reviewed Oct 4, 2018
View reviewed changes
aten/src/ATen/native/sparse/SparseTensor.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@realdoug realdoug force-pushed the dense2sparse branch 2 times, most recently from facfac6 to 4b8027e Compare October 5, 2018 04:46
@weiyangfb
Copy link
Contributor

weiyangfb commented Oct 5, 2018

CIs failed look related

@djsaunde djsaunde mentioned this pull request Oct 7, 2018
Open
@realdoug realdoug force-pushed the dense2sparse branch 5 times, most recently from 0823819 to 840624c Compare October 11, 2018 18:40
@realdoug
Copy link
Contributor Author

realdoug commented Oct 11, 2018

@weiyangfb ok ready for review again

weiyangfb
weiyangfb reviewed Oct 11, 2018
View reviewed changes
test/test_sparse.py Outdated

This comment was marked as off-topic.

Sign in to view

weiyangfb
weiyangfb reviewed Oct 11, 2018
View reviewed changes
test/test_sparse.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

weiyangfb
weiyangfb reviewed Oct 11, 2018
View reviewed changes
test/test_sparse.py Outdated

This comment was marked as off-topic.

Sign in to view

weiyangfb
weiyangfb reviewed Oct 11, 2018
View reviewed changes
test/test_sparse.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

weiyangfb
weiyangfb reviewed Oct 11, 2018
View reviewed changes
aten/src/ATen/native/sparse/SparseTensor.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

weiyangfb
weiyangfb reviewed Oct 11, 2018
View reviewed changes
torch/_tensor_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

@realdoug realdoug mentioned this pull request Oct 14, 2018
Closed
@realdoug realdoug force-pushed the dense2sparse branch 2 times, most recently from f30d038 to e7a624a Compare October 17, 2018 21:30
weiyangfb
weiyangfb approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@weiyangfb weiyangfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there are some minor nits

@realdoug
Copy link
Contributor Author

realdoug commented Oct 22, 2018

@weiyangfb sounds good, done & done!

@realdoug realdoug force-pushed the dense2sparse branch 2 times, most recently from 6ff7c27 to dbff197 Compare October 23, 2018 16:22
@realdoug
Copy link
Contributor Author

realdoug commented Oct 23, 2018

build failures were due to #12984. Retriggered the build via rebase

@weiyangfb weiyangfb self-assigned this Oct 23, 2018
@weiyangfb
Copy link
Contributor

weiyangfb commented Oct 24, 2018

@realdoug please rebase to fix the CI failures

weiyangfb
weiyangfb reviewed Oct 25, 2018
View reviewed changes
aten/src/ATen/native/native_functions.yaml Outdated

This comment was marked as off-topic.

Sign in to view

@realdoug realdoug force-pushed the dense2sparse branch 2 times, most recently from 3cc749f to cd62fcd Compare October 25, 2018 02:07
weiyangfb
weiyangfb reviewed Oct 25, 2018
View reviewed changes
aten/src/ATen/native/sparse/SparseTensor.cpp Outdated

This comment was marked as off-topic.

Sign in to view

weiyangfb
weiyangfb reviewed Oct 25, 2018
View reviewed changes
aten/src/ATen/native/sparse/SparseTensor.cpp Outdated

This comment was marked as off-topic.

Sign in to view

weiyangfb
weiyangfb reviewed Oct 25, 2018
View reviewed changes
torch/_tensor_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

weiyangfb
weiyangfb reviewed Oct 25, 2018
View reviewed changes
torch/_tensor_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

weiyangfb
weiyangfb reviewed Oct 25, 2018
View reviewed changes
aten/src/ATen/native/sparse/SparseTensor.cpp Outdated

This comment was marked as off-topic.

Sign in to view

weiyangfb
weiyangfb reviewed Oct 25, 2018
View reviewed changes
aten/src/ATen/native/sparse/SparseTensor.cpp Outdated

This comment was marked as off-topic.

Sign in to view

facebook-github-bot
facebook-github-bot reviewed Oct 25, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weiyangfb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@weiyangfb
Copy link
Contributor

weiyangfb commented Oct 26, 2018

need a rebase :(

facebook-github-bot
facebook-github-bot reviewed Oct 26, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weiyangfb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Oct 27, 2018
@realdoug @facebook-github-bot
dense.to_sparse() re: #8853 (#12171)
6aab0a7 
Summary:
Here is my stab at ```dense.to_sparse```
Pull Request resolved: pytorch/pytorch#12171

Differential Revision: D10859078

Pulled By: weiyangfb

fbshipit-source-id: 5df72f72ba4f8f10e283402ff7731fd535682664
@weiyangfb
Copy link
Contributor

weiyangfb commented Oct 27, 2018

landed, Thanks @realdoug !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssnl ssnl ssnl left review comments

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@ezyang ezyang Awaiting requested review from ezyang

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

@zdevito zdevito Awaiting requested review from zdevito

@zou3519 zou3519 Awaiting requested review from zou3519

+3 more reviewers

@bddppq bddppq bddppq left review comments

@vishwakftw vishwakftw vishwakftw left review comments

@weiyangfb weiyangfb weiyangfb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@weiyangfb weiyangfb

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@realdoug @weiyangfb @bddppq @iotamudelta @ssnl @facebook-github-bot @vishwakftw @ezyang