Upgrade mkldnn bridge to reduce overhead of bridge itself#12164
Upgrade mkldnn bridge to reduce overhead of bridge itself#12164gujinghui wants to merge 1 commit intopytorch:masterfrom
Conversation
47c359c to
e6bb797
Compare
|
@yinghai have no idead on the failure of "ci/circleci: Config Processing Error" |
e6bb797 to
298d44f
Compare
|
@pytorchbot retest this please |
facebook-github-bot
left a comment
There was a problem hiding this comment.
wesolwsk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@wesolwsk |
|
@gujinghui - I am getting conflicts when pulling from intel/mkl-dnn into our local repo. I will investigate further. Trying to get this done this week. |
|
@wesolwsk Please let us know anything that we can help. We are glad to help. |
298d44f to
5b1dda5
Compare
|
@wesolwsk |
facebook-github-bot
left a comment
There was a problem hiding this comment.
wesolwsk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Signed-off-by: Gu, Jinghui <jinghui.gu@intel.com>
5b1dda5 to
0b6fbab
Compare
|
@wesolwsk |
|
@gujinghui Which commit of the bug fix is it? |
|
@yinghai, do we still need this after the mkl-dnn an ideep upgrades? |
|
@wesolwsk Yeah, we still need this. But @gujinghui seems to have force push this PR to update the IDEEP version again. We need to check whether it's in our internal repo first. |
|
@yinghai The "bug fix" @gujinghui referred to should be the one below which is about INT8 support so should be OK to ignore this time: |
|
@wesolwsk ok to merge? |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@wesolwsk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…torch#12164)" This reverts commit 4b7c615.
|
@gujinghui I'm reverting this as it's breaking the master. It probably needs a rebase and resubmission. |
|
@yinghai |
Upgrade mkldnn bridge to reduce overhead of bridge itself