Skip to content

[Inductor Cutlass backend] Move tests to separate file#121489

Closed
kadeng wants to merge 3 commits into
gh/kadeng/39/basefrom
gh/kadeng/39/head
Closed

[Inductor Cutlass backend] Move tests to separate file#121489
kadeng wants to merge 3 commits into
gh/kadeng/39/basefrom
gh/kadeng/39/head

Conversation

@kadeng

@kadeng kadeng commented Mar 8, 2024 •
edited by pytorch-bot Bot
Loading

Copy link
Copy Markdown
Contributor

@pytorch-bot pytorch-bot Bot added the topic: not user facing topic category label Mar 8, 2024
@pytorch-bot

pytorch-bot Bot commented Mar 8, 2024 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121489

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6f1d64b with merge base 86a2d67 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Mar 8, 2024
Closed
Closed
Closed
@kadeng
Update on "[Inductor Cutlass backend] Move tests to separate file"
767f4f8 
Move Cutlass backend related tests to test/inductor/test_cutlass_backend.py - no changes to the tests themselves.


[ghstack-poisoned]
@kadeng kadeng mentioned this pull request Mar 8, 2024
Closed
@kadeng kadeng requested review from aakhundov and jansel March 11, 2024 11:42
@kadeng kadeng marked this pull request as ready for review March 11, 2024 11:43
@kadeng kadeng requested a review from a team as a code owner March 11, 2024 11:43
@aakhundov

aakhundov commented Mar 11, 2024

Copy link
Copy Markdown
Contributor

@kadeng there are 14 failing jobs, but I don't see as many in the trunk: https://hud.pytorch.org/ . Could you rebase, maybe onto viable/strict?

jansel
jansel approved these changes Mar 12, 2024
View reviewed changes

@jansel jansel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is moving stuff around now changing anything

@kadeng
Update on "[Inductor Cutlass backend] Move tests to separate file"
6f1d64b 
Move Cutlass backend related tests to test/inductor/test_cutlass_backend.py - no changes to the tests themselves.


[ghstack-poisoned]
@kadeng

kadeng commented Mar 12, 2024

Copy link
Copy Markdown
Contributor Author

@kadeng there are 14 failing jobs, but I don't see as many in the trunk: https://hud.pytorch.org/ . Could you rebase, maybe onto viable/strict?

Did that by cherry-picking on top of a recent clean viable/strict checkout, CI is running again.

@kadeng kadeng mentioned this pull request Mar 12, 2024
Closed
@kadeng

kadeng commented Mar 12, 2024

Copy link
Copy Markdown
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 12, 2024
@pytorchmergebot

pytorchmergebot commented Mar 12, 2024

Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kadeng kadeng mentioned this pull request Mar 12, 2024
Closed
@alexsamardzic alexsamardzic mentioned this pull request Mar 12, 2024
Closed
@github-actions github-actions Bot deleted the gh/kadeng/39/head branch April 12, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@aakhundov aakhundov Awaiting requested review from aakhundov

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kadeng @aakhundov @pytorchmergebot @jansel