ATen/test/basic.cpp: Catch2Gtest#12142
Closed
zrphercule wants to merge 16 commits intopytorch:masterfrom
zrphercule:catch2gtest_basic
Closed
ATen/test/basic.cpp: Catch2Gtest#12142zrphercule wants to merge 16 commits intopytorch:masterfrom zrphercule:catch2gtest_basic
zrphercule wants to merge 16 commits intopytorch:masterfrom
zrphercule:catch2gtest_basic
Conversation
ezyang
approved these changes
Nov 6, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
goldsborough
approved these changes
Nov 6, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 6, 2018
Summary: In #11846 , we immigranted all catch tests in Aten/test/ to use gtest except of basic.cpp for a GPU bug (valgrind related). In this PR, we will find out what the bug is, and immigrant last piece of aten catch to use gtest. Pull Request resolved: pytorch/pytorch#12142 Differential Revision: D12946980 Pulled By: zrphercule fbshipit-source-id: cf3b21f23ddec3e363ac8ec4bdeb4bc4fe35f83b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #11846 , we immigranted all catch tests in Aten/test/ to use gtest except of basic.cpp for a GPU bug (valgrind related).
In this PR, we will find out what the bug is, and immigrant last piece of aten catch to use gtest.