Move torchbench model configuration into a YAML file.#120299
Closed
ysiraichi wants to merge 5 commits intogh/ysiraichi/59/basefrom
Closed
Move torchbench model configuration into a YAML file.#120299ysiraichi wants to merge 5 commits intogh/ysiraichi/59/basefrom
ysiraichi wants to merge 5 commits intogh/ysiraichi/59/basefrom
Conversation
This PR moves other aspects of torchbench's model configuration (e.g. batch size, tolerance requirements, etc.) into a new YAML file: `torchbench.yaml`. It also merges the recently added `torchbench_skip_models.yaml` file inside the `skip` key. This is an effort so that external consumers are able to easily replicate the performance results and coverage results from the PyTorch HUD. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120299
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 59ecec6 with merge base edf1c4e ( UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR moves other aspects of torchbench's model configuration (e.g. batch size, tolerance requirements, etc.) into a new YAML file: `torchbench.yaml`. It also merges the recently added `torchbench_skip_models.yaml` file inside the `skip` key. This is an effort so that external consumers are able to easily replicate the performance results and coverage results from the PyTorch HUD. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng miladm [ghstack-poisoned]
This PR moves other aspects of torchbench's model configuration (e.g. batch size, tolerance requirements, etc.) into a new YAML file: `torchbench.yaml`. It also merges the recently added `torchbench_skip_models.yaml` file inside the `skip` key. This is an effort so that external consumers are able to easily replicate the performance results and coverage results from the PyTorch HUD. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng miladm [ghstack-poisoned]
ysiraichi
added a commit
that referenced
this pull request
Feb 21, 2024
This PR moves other aspects of torchbench's model configuration (e.g. batch size, tolerance requirements, etc.) into a new YAML file: `torchbench.yaml`. It also merges the recently added `torchbench_skip_models.yaml` file inside the `skip` key. This is an effort so that external consumers are able to easily replicate the performance results and coverage results from the PyTorch HUD. ghstack-source-id: d6f7308 Pull Request resolved: #120299
Contributor
|
Didn't I see another YAML PR? Is this the same thing? |
Collaborator
Author
|
Yes. That was #120117. The difference is that we moved only skips to the YAML file. Now, we are moving every list/dict of models that we need for any specific configuration. We figured we would need those when trying to replicate PyTorch HUD results. |
This PR moves other aspects of torchbench's model configuration (e.g. batch size, tolerance requirements, etc.) into a new YAML file: `torchbench.yaml`. It also merges the recently added `torchbench_skip_models.yaml` file inside the `skip` key. This is an effort so that external consumers are able to easily replicate the performance results and coverage results from the PyTorch HUD. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng miladm [ghstack-poisoned]
ysiraichi
added a commit
that referenced
this pull request
Feb 22, 2024
This PR moves other aspects of torchbench's model configuration (e.g. batch size, tolerance requirements, etc.) into a new YAML file: `torchbench.yaml`. It also merges the recently added `torchbench_skip_models.yaml` file inside the `skip` key. This is an effort so that external consumers are able to easily replicate the performance results and coverage results from the PyTorch HUD. ghstack-source-id: 2a37939 Pull Request resolved: #120299
Collaborator
Author
|
It doesn't look like the CI failure is related to this PR. |
Collaborator
Author
jansel
approved these changes
Feb 23, 2024
Collaborator
|
@pytorchbot merge |
Collaborator
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
Collaborator
|
@pytorchbot merge -r |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
This PR moves other aspects of torchbench's model configuration (e.g. batch size, tolerance requirements, etc.) into a new YAML file: `torchbench.yaml`. It also merges the recently added `torchbench_skip_models.yaml` file inside the `skip` key. This is an effort so that external consumers are able to easily replicate the performance results and coverage results from the PyTorch HUD. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng miladm [ghstack-poisoned]
Collaborator
|
Successfully rebased |
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 23, 2024
This PR moves other aspects of torchbench's model configuration (e.g. batch size, tolerance requirements, etc.) into a new YAML file: `torchbench.yaml`. It also merges the recently added `torchbench_skip_models.yaml` file inside the `skip` key. This is an effort so that external consumers are able to easily replicate the performance results and coverage results from the PyTorch HUD. ghstack-source-id: c1eaece Pull Request resolved: #120299
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Feb 24, 2024
Summary: This PR moves other aspects of torchbench's model configuration (e.g. batch size, tolerance requirements, etc.) into a new YAML file: `torchbench.yaml`. It also merges the recently added `torchbench_skip_models.yaml` file inside the `skip` key. This is an effort so that external consumers are able to easily replicate the performance results and coverage results from the PyTorch HUD. X-link: pytorch/pytorch#120299 Approved by: https://github.com/jansel Reviewed By: jeanschmidt Differential Revision: D54123721 fbshipit-source-id: c6e69269775fa8a70021fe13313293a527c6b3e1
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 27, 2024
Similar to #120299 Pull Request resolved: #131724 Approved by: https://github.com/shunting314
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Jul 30, 2024
Summary: Similar to pytorch/pytorch#120299 X-link: pytorch/pytorch#131724 Approved by: https://github.com/shunting314 Reviewed By: ZainRizvi Differential Revision: D60431445 Pulled By: kit1980 fbshipit-source-id: 0674b8d66459d92edd4cc4f65af984989a2fb31a
pbielak
added a commit
to intel/torch-xpu-ops
that referenced
this pull request
Mar 11, 2026
- Re-enable `detectron2_maskrcnn` skip in skip.all. - Re-enable all `timm_*` model skips in skip.all. - Keep explicit upstream PR context comments for `modded_nanogpt` and `pytorch_CycleGAN_and_pix2pix`. - Remove stale expected-accuracy rows for skipped models. Relevant PRs: [1] pytorch/pytorch#120299 [2] pytorch/pytorch#164816 [3] pytorch/pytorch#172125 [4] pytorch/pytorch#175066 [5] #2306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR moves other aspects of torchbench's model configuration (e.g. batch size,
tolerance requirements, etc.) into a new YAML file:
torchbench.yaml. It also merges therecently added
torchbench_skip_models.yamlfile inside theskipkey.This is an effort so that external consumers are able to easily replicate the performance
results and coverage results from the PyTorch HUD.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng @miladm