Miscellaneous updates for CUDA 10#12017
Closed
syed-ahmed wants to merge 2 commits intopytorch:masterfrom
Closed
Conversation
…an cache size bug has been fixed in CUDA10
Co-authored-by: Christian Sarofeen <csarofeen@nvidia.com>
zou3519
approved these changes
Sep 24, 2018
soumith
approved these changes
Sep 24, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 24, 2018
Summary: This PR has some updates related to CUDA 10. - pytorch/pytorch@c2195e9 ensures that the repo successfully builts on CUDA 10. Addresses pytorch/pytorch#11888 - pytorch/pytorch@423d8d3 follows up on the cufft max plan number bug: pytorch/pytorch#11089, which has been fixed in CUDA 10. Pull Request resolved: pytorch/pytorch#12017 Differential Revision: D10013405 Pulled By: soumith fbshipit-source-id: 5bc6d7f71d5133f7821b407b1ac6c51bef0f6fa8
ssnl
reviewed
Sep 28, 2018
| // bug related to cuFFT plan cache max size has been fixed | ||
| // in CUDA 10. Hence, when compiling with CUDA 10, just | ||
| // don't do the erase. | ||
| #if CUDA_VERSION < 10000 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ssnl
reviewed
Sep 28, 2018
| @@ -346,6 +346,7 @@ class CuFFTConfig { | |||
| // be fine for now. | |||
| // TODO: When CUDA 10 comes out, check if the bug is fixed or if we need another | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 12, 2018
Summary: SsnL As per your review in #12017, I added a max plan number for CUDA 10 path. Our internal cuFFT team couldn't suggest a number since the limit depends on host/device memory. That is, a plan allocates some buffers on the device and also creates objects for the plans on the host side. I raised this number to 4x arbitrarily per you suggestion. Pull Request resolved: #12553 Differential Revision: D10320832 Pulled By: SsnL fbshipit-source-id: 3148d45cd280dffb2039756e2f6a74fbc7aa086d
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 12, 2018
Summary: SsnL As per your review in pytorch/pytorch#12017, I added a max plan number for CUDA 10 path. Our internal cuFFT team couldn't suggest a number since the limit depends on host/device memory. That is, a plan allocates some buffers on the device and also creates objects for the plans on the host side. I raised this number to 4x arbitrarily per you suggestion. Pull Request resolved: pytorch/pytorch#12553 Differential Revision: D10320832 Pulled By: SsnL fbshipit-source-id: 3148d45cd280dffb2039756e2f6a74fbc7aa086d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has some updates related to CUDA 10.