Skip to content

Updating sleef submodule to eb3d97785 to fix export errors#119953

Closed
anthonyalayo wants to merge 3 commits intopytorch:mainfrom
anthonyalayo:anthonyalayo-update-sleef-eb3d97785
Closed

Updating sleef submodule to eb3d97785 to fix export errors#119953
anthonyalayo wants to merge 3 commits intopytorch:mainfrom
anthonyalayo:anthonyalayo-update-sleef-eb3d97785

Conversation

@anthonyalayo
Copy link
Copy Markdown
Contributor

@anthonyalayo anthonyalayo commented Feb 15, 2024

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 15, 2024
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Feb 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119953

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit f900778 with merge base b4252d7 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@anthonyalayo
Copy link
Copy Markdown
Contributor Author

cc @malfet who last updated this dependency

@anthonyalayo
Copy link
Copy Markdown
Contributor Author

I just tested this with my project, worked like a charm.

ezyang
ezyang previously approved these changes Feb 15, 2024
@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented Feb 15, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 15, 2024
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

This PR updates submodules third_party/sleef

If those updates are intentional, please add "submodule" keyword to PR title/description.

@anthonyalayo anthonyalayo changed the title Updating sleef to eb3d97785 to fix export errors [submodule] Updating sleef to eb3d97785 to fix export errors Feb 15, 2024
@anthonyalayo anthonyalayo changed the title [submodule] Updating sleef to eb3d97785 to fix export errors Updating sleef submodule to eb3d97785 to fix export errors Feb 15, 2024
@anthonyalayo
Copy link
Copy Markdown
Contributor Author

I'm checking out those build errors, I didn't see those on my local (clang 15, arm64 OSX)

In file included from /var/lib/jenkins/workspace/aten/src/ATen/cpu/vec/vec256/vec256.h:12,
                 from /var/lib/jenkins/workspace/aten/src/ATen/cpu/vec/vec.h:6,
                 from /var/lib/jenkins/workspace/aten/src/ATen/cpu/vec/functional_base.h:6,
                 from /var/lib/jenkins/workspace/aten/src/ATen/cpu/vec/functional.h:3,
                 from /var/lib/jenkins/workspace/aten/src/ATen/native/cpu/UnaryOpsKernel.cpp:12,
                 from /var/lib/jenkins/workspace/build/aten/src/ATen/native/cpu/UnaryOpsKernel.cpp.AVX2.cpp:1:
/var/lib/jenkins/workspace/aten/src/ATen/cpu/vec/vec256/vec256_bfloat16.h: In instantiation of ‘at::vec::AVX2::Vectorized<T> at::vec::AVX2::Vectorized16<T>::log() const [with T = c10::BFloat16]’:
/var/lib/jenkins/workspace/aten/src/ATen/native/cpu/UnaryOpsKernel.cpp:142:3:   required from here
/var/lib/jenkins/workspace/aten/src/ATen/cpu/vec/vec256/vec256_bfloat16.h:482:16: error: invalid conversion from ‘__m256 (*)(__m256)’ to ‘const __m256 (*)(__m256)’ [-fpermissive]
  482 |     return map(Sleef_logf8_u10);
      |                ^~~~~~~~~~~~~~~
      |                |
      |                __m256 (*)(__m256)

Most likely due to -fpermissive not affecting my build environment. First i'm going to try it on gcc 10 since I have that readily available.

@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Feb 15, 2024
@anthonyalayo
Copy link
Copy Markdown
Contributor Author

@pytorchbot label "topic: not user facing"

@anthonyalayo
Copy link
Copy Markdown
Contributor Author

alright that should fixed everything, should be good for another merge attempt in the morning @ezyang

@anthonyalayo
Copy link
Copy Markdown
Contributor Author

Those errors are unrelated @ezyang

@anthonyalayo
Copy link
Copy Markdown
Contributor Author

Can we start the merge on this again @ezyang ?

@anthonyalayo
Copy link
Copy Markdown
Contributor Author

cc @malfet for the merge, hoping to get this in before it's stale

@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented Feb 19, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Copy Markdown
Contributor

atalman commented Feb 19, 2024

@pytorchbot revert -c nosignal -m "Broke trunk linux-focal-cpu-py3.10-gcc9-bazel-test and linux-focal-cuda12.1-py3.10-gcc9-bazel-test. These are not flaky failures."

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Feb 19, 2024
…119953)"

This reverts commit fa9cbdc.

Reverted #119953 on behalf of https://github.com/atalman due to Broke trunk linux-focal-cpu-py3.10-gcc9-bazel-test and linux-focal-cuda12.1-py3.10-gcc9-bazel-test. These are not flaky failures. ([comment](#119953 (comment)))
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@anthonyalayo your PR has been successfully reverted.

@pytorch-bot pytorch-bot bot dismissed ezyang’s stale review February 19, 2024 20:26

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

@anthonyalayo
Copy link
Copy Markdown
Contributor Author

@atalman can I get more details about how it failed after merge? That test was passing before merge.

@atalman
Copy link
Copy Markdown
Contributor

atalman commented Feb 19, 2024

@anthonyalayo : This is the failure: https://github.com/pytorch/pytorch/actions/runs/7913413809/job/21611696506#step:12:1824 It showed up as flaky on the PR. However it does not look like flaky. The two failures you can also see here : https://hud.pytorch.org/hud/pytorch/pytorch/main/1?per_page=50&name_filter=inux-focal-c

@anthonyalayo
Copy link
Copy Markdown
Contributor Author

Thanks @atalman taking a look

@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 20, 2024
pytorchmergebot pushed a commit to wangjiangben-hw/pytorch that referenced this pull request Feb 22, 2024
pytorchmergebot added a commit to wangjiangben-hw/pytorch that referenced this pull request Feb 22, 2024
…ytorch#119953)"

This reverts commit fa9cbdc.

Reverted pytorch#119953 on behalf of https://github.com/atalman due to Broke trunk linux-focal-cpu-py3.10-gcc9-bazel-test and linux-focal-cuda12.1-py3.10-gcc9-bazel-test. These are not flaky failures. ([comment](pytorch#119953 (comment)))
@github-actions
Copy link
Copy Markdown
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) open source Reverted Stale topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building via FetchContent and exporting via install results in missing "sleef" target

6 participants