Updating sleef submodule to eb3d97785 to fix export errors#119953
Updating sleef submodule to eb3d97785 to fix export errors#119953anthonyalayo wants to merge 3 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119953
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Unrelated FailureAs of commit f900778 with merge base b4252d7 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
cc @malfet who last updated this dependency |
|
I just tested this with my project, worked like a charm. |
|
@pytorchbot merge |
|
This PR updates submodules third_party/sleef If those updates are intentional, please add "submodule" keyword to PR title/description. |
|
I'm checking out those build errors, I didn't see those on my local (clang 15, arm64 OSX) Most likely due to |
|
@pytorchbot label "topic: not user facing" |
|
alright that should fixed everything, should be good for another merge attempt in the morning @ezyang |
|
Those errors are unrelated @ezyang |
|
Can we start the merge on this again @ezyang ? |
|
cc @malfet for the merge, hoping to get this in before it's stale |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -c nosignal -m "Broke trunk linux-focal-cpu-py3.10-gcc9-bazel-test and linux-focal-cuda12.1-py3.10-gcc9-bazel-test. These are not flaky failures." |
|
@pytorchbot successfully started a revert job. Check the current status here. |
…119953)" This reverts commit fa9cbdc. Reverted #119953 on behalf of https://github.com/atalman due to Broke trunk linux-focal-cpu-py3.10-gcc9-bazel-test and linux-focal-cuda12.1-py3.10-gcc9-bazel-test. These are not flaky failures. ([comment](#119953 (comment)))
|
@anthonyalayo your PR has been successfully reverted. |
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
|
@atalman can I get more details about how it failed after merge? That test was passing before merge. |
|
@anthonyalayo : This is the failure: https://github.com/pytorch/pytorch/actions/runs/7913413809/job/21611696506#step:12:1824 It showed up as flaky on the PR. However it does not look like flaky. The two failures you can also see here : https://hud.pytorch.org/hud/pytorch/pytorch/main/1?per_page=50&name_filter=inux-focal-c |
|
Thanks @atalman taking a look |
…19953) Fixes pytorch#119952 with submodule updates Pull Request resolved: pytorch#119953 Approved by: https://github.com/ezyang
…ytorch#119953)" This reverts commit fa9cbdc. Reverted pytorch#119953 on behalf of https://github.com/atalman due to Broke trunk linux-focal-cpu-py3.10-gcc9-bazel-test and linux-focal-cuda12.1-py3.10-gcc9-bazel-test. These are not flaky failures. ([comment](pytorch#119953 (comment)))
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Fixes #119952 with submodule updates
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10