Skip to content

[build][c10] set up c10 scaffolding. Move macros proper first.#11939

Closed
Yangqing wants to merge 1 commit intopytorch:masterfrom
Yangqing:c10
Closed

[build][c10] set up c10 scaffolding. Move macros proper first.#11939
Yangqing wants to merge 1 commit intopytorch:masterfrom
Yangqing:c10

Conversation

@Yangqing
Copy link
Contributor

No description provided.

CMakeLists.txt Outdated

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@Yangqing Yangqing requested review from bwasti and ezyang September 21, 2018 21:33
@Yangqing Yangqing changed the title [wip] set up c10 scaffolding. Move macros proper first. [build][c10] set up c10 scaffolding. Move macros proper first. Sep 22, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yangqing has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yangqing has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yangqing has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Pull Request resolved: pytorch#11939

Differential Revision: D10004629

fbshipit-source-id: f9ba2ccfc33cf1e7620bf3b271cf370ae422f863
@Yangqing
Copy link
Contributor Author

@pytorchbot retest this please. Seems like a CI system error on mac.

@Yangqing
Copy link
Contributor Author

OK, this one should be correct because last run had mac errors due to ci system, this time mac passed, and mkl is erroring out due to timeout, but mkl already passed last time. No code change between the two runs.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Sep 24, 2018
Summary: Pull Request resolved: pytorch/pytorch#11939

Reviewed By: orionr, dzhulgakov

Differential Revision: D10004629

Pulled By: Yangqing

fbshipit-source-id: ba50a96820d35c7922d81c78c4cbe849c85c251c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants