Fix docstring of torch.jit.createResolutionCallback#11921
Closed
zasdfgbnm wants to merge 2 commits intopytorch:masterfrom
Closed
Fix docstring of torch.jit.createResolutionCallback#11921zasdfgbnm wants to merge 2 commits intopytorch:masterfrom
torch.jit.createResolutionCallback#11921zasdfgbnm wants to merge 2 commits intopytorch:masterfrom
Conversation
soumith
approved these changes
Sep 21, 2018
Collaborator
|
./torch/jit/init.py:532:1: W293 blank line contains whitespace |
Collaborator
Author
|
@soumith fixed |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
iotamudelta
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Sep 21, 2018
Summary: The sample code in the docstring of `torch.jit.createResolutionCallback` is not working: `createResolutionCallback()` gets the frame of `bar`. In order to get the frame of `baz`, one need to use `createResolutionCallback(1)` Pull Request resolved: pytorch#11921 Differential Revision: D9989123 Pulled By: soumith fbshipit-source-id: a7166defdccbbf6979f7df4c871298e6b9a2b415
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sample code in the docstring of
torch.jit.createResolutionCallbackis not working:createResolutionCallback()gets the frame ofbar. In order to get the frame ofbaz, one need to usecreateResolutionCallback(1)