Fix Array.h when compiled with C++17#11816
Closed
ezyang wants to merge 3 commits intopytorch:masterfrom
Closed
Conversation
d164366 to
775bb74
Compare
775bb74 to
c33b1e4
Compare
Summary: Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch#11819 Differential Revision: D9928730 fbshipit-source-id: e9a7a4723097beaad7e2c8ee63c5809451e6d50a
… from tensor_impl.h from context_base.h" Summary: Original commit changeset: 0d1792804d73 Differential Revision: D9940725 fbshipit-source-id: 7e03ffe660f95f9ee46968b9160c74d790b6a9b9
Summary: Pull Request resolved: pytorch#11816 The file isn't in the std:: namespace, so is_same must be qualified. Reviewed By: smessmer Differential Revision: D9923774 fbshipit-source-id: 1d53f11203b4f53c624cf78131601be3d264b522
c33b1e4 to
902a6d8
Compare
gchanan
approved these changes
Sep 19, 2018
Contributor
gchanan
left a comment
There was a problem hiding this comment.
there's a bunch of other stuff in here as well...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The file isn't in the std:: namespace, so is_same
must be qualified.
Reviewed By: smessmer
Differential Revision: D9923774