Turn storage on UndefinedTensorImpl into nullptr.#11738
Closed
Turn storage on UndefinedTensorImpl into nullptr.#11738
Conversation
Differential Revision: D9847859 Differential Version: 57954347
gchanan
approved these changes
Sep 17, 2018
Contributor
gchanan
left a comment
There was a problem hiding this comment.
conflicts, and also the constructors dont match what is in ATen (though that's a different PR).
smessmer
reviewed
Sep 17, 2018
caffe2/core/tensor_impl.h
Outdated
| class CAFFE2_API TensorImpl : public c10::intrusive_ptr_target { | ||
| public: | ||
| TensorImpl() = delete; | ||
| explicit TensorImpl(at::Storage&& storage) : storage_(storage) {} |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
smessmer
approved these changes
Sep 17, 2018
Differential Revision: D9847859 Differential Version: 58101637
Differential Revision: D9847859 Differential Version: 58102783
iotamudelta
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Sep 21, 2018
Summary: I also fix a bug that crept in while we had incorrect semantics where UndefinedTensorImpl was a CPU tensor, and thus some moves which shouldn't have been legal didn't crash. Moving out the Tensor* also moved out the Tensor* in the blob, and it's not supported to store an undefined tensor in a blob. Pull Request resolved: pytorch#11738 Reviewed By: gchanan Differential Revision: D9847859 fbshipit-source-id: db6be0f76a8e6526a89fd0e87b6a23b9cc820c8d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #11738 Turn storage on UndefinedTensorImpl into nullptr. 💚
Differential Revision: D9847859