USE CAFFE_ENFORCE_EQ_WITH_CALLER in TensorImpl.#11721
Closed
gchanan wants to merge 1 commit intopytorch:masterfrom
Closed
USE CAFFE_ENFORCE_EQ_WITH_CALLER in TensorImpl.#11721gchanan wants to merge 1 commit intopytorch:masterfrom
gchanan wants to merge 1 commit intopytorch:masterfrom
Conversation
The file that declares CAFFE_ENFORCE_EQ_WITH_CALLER pollutes the global namespace with things like MAX, MIN, CHECK, so I renamed these in places where this is a problem. Long term we should probably clean up the file.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Sep 14, 2018
ezyang
added a commit
to ezyang/pytorch
that referenced
this pull request
Sep 18, 2018
Summary: Pull Request resolved: pytorch#11805 Some of our headers in Caffe2 pollute the macro namespace with things like MAX, MIN, CHECK, so I renamed these in places where this is a problem. This patch courtesy of gchanan, extracted out of pytorch#11721 Differential Revision: D9917757 fbshipit-source-id: 174443e3d6eb10e421d59535e2ecad3eaca99c84
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 18, 2018
Summary: Pull Request resolved: #11805 Some of our headers in Caffe2 pollute the macro namespace with things like MAX, MIN, CHECK, so I renamed these in places where this is a problem. This patch courtesy of gchanan, extracted out of #11721 Reviewed By: Yangqing Differential Revision: D9917757 fbshipit-source-id: 17fc692ca04b208dcb8ae00731ed60e393284f7c
Collaborator
|
@gchanan do we still want this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file that declares CAFFE_ENFORCE_EQ_WITH_CALLER pollutes the global namespace with things like MAX, MIN, CHECK, so I renamed these in places where this is a problem.
Long term we should probably clean up the file.