[dynamo] fix functools.reduce() function with None as initial#116398
Closed
XuehaiPan wants to merge 2 commits intopytorch:mainfrom
Closed
[dynamo] fix functools.reduce() function with None as initial#116398XuehaiPan wants to merge 2 commits intopytorch:mainfrom
functools.reduce() function with None as initial#116398XuehaiPan wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116398
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 116948d with merge base c7e9c15 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
reviewed
Dec 25, 2023
| ) | ||
|
|
||
| def call_reduce(self, tx, function, iterable, initializer=None): | ||
| def call_reduce(self, tx, function, iterable, initial=_SENTINEL): |
Collaborator
There was a problem hiding this comment.
Oh, gosh this seems really hacky, but it is unfortunately, the best way to do it... Sigh...
Skylion007
approved these changes
Dec 25, 2023
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Jan 2, 2024
Summary:
The `initial` argument in `functools.reduce` can be `None`.
```python
initial_missing = object()
def reduce(function, iterable, initial=initial_missing, /):
it = iter(iterable)
if initial is initial_missing:
value = next(it)
else:
value = initial
for element in it:
value = function(value, element)
return value
```
Reference:
- python/cpython#102759
X-link: pytorch/pytorch#116398
Approved by: https://github.com/Skylion007
Reviewed By: izaitsevfb, jeanschmidt
Differential Revision: D52424773
fbshipit-source-id: 36d3a6f5f5786350fe8c325773deb135ccbd48e9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
initialargument infunctools.reducecan beNone.Reference:
functools.reducebetween code and documentation python/cpython#102759cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng