Skip to content

OperatorDef <==> NodeProto Conversion#11621

Closed
houseroad wants to merge 1 commit intopytorch:masterfrom
houseroad:onnxpp
Closed

OperatorDef <==> NodeProto Conversion#11621
houseroad wants to merge 1 commit intopytorch:masterfrom
houseroad:onnxpp

Conversation

@houseroad
Copy link
Member

@houseroad houseroad commented Sep 13, 2018

Operator level proto conversion between (new) torch proto and (old) caffe2 proto.

@houseroad houseroad changed the title OperatorDef <==> NodeProto Conversion [WIP] OperatorDef <==> NodeProto Conversion Sep 13, 2018
@houseroad houseroad changed the title [WIP] OperatorDef <==> NodeProto Conversion OperatorDef <==> NodeProto Conversion Sep 18, 2018
xiaomengy
xiaomengy reviewed Sep 18, 2018
View reviewed changes
caffe2/proto/torch_pb.h Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/python/pybind_state.cc Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/python/pybind_state.cc Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/utils/proto_convert.cc Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/utils/proto_convert.cc Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/utils/proto_convert.h Outdated

This comment was marked as off-topic.

Sign in to view

facebook-github-bot
facebook-github-bot reviewed Sep 18, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

xiaomengy
xiaomengy approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@xiaomengy xiaomengy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dzhulgakov
dzhulgakov reviewed Sep 18, 2018
View reviewed changes
caffe2/python/pybind_state.cc Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@houseroad @facebook-github-bot
OperatorDef <==> NodeProto Conversion (pytorch#11621)
f26afb5 
Summary:
Operator level proto conversion between (new) torch proto and (old) caffe2 proto.
Pull Request resolved: pytorch#11621

Reviewed By: BIT-silence

Differential Revision: D9892422

Pulled By: BIT-silence

fbshipit-source-id: f792a8c388aeec3382ee6b264b4101334d45dc36
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@dzhulgakov dzhulgakov dzhulgakov left review comments

+1 more reviewer

@xiaomengy xiaomengy xiaomengy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

caffe2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@houseroad @xiaomengy @facebook-github-bot @dzhulgakov @ezyang @pytorchbot