Skip to content

[Easy][BE]: remove itertools.accumulate Python 2 shim and apply UFMT#116192

Closed
Skylion007 wants to merge 2 commits intopytorch:mainfrom
Skylion007:skylion007/remove-accumulate-shim-2023-12-20
Closed

[Easy][BE]: remove itertools.accumulate Python 2 shim and apply UFMT#116192
Skylion007 wants to merge 2 commits intopytorch:mainfrom
Skylion007:skylion007/remove-accumulate-shim-2023-12-20

Conversation

@Skylion007
Copy link
Copy Markdown
Collaborator

Removes an unnecessary duplicated utility functions and just have it rely on itertools. Since the file is low traffic, I also added the modified files to UFMT'd files and formatted them.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Dec 20, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116192

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 73cc7a8 with merge base c215e59 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the release notes: dataloader release notes category label Dec 20, 2023
@Skylion007
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 20, 2023
@Skylion007 Skylion007 added better-engineering Relatively self-contained tasks for better engineering contributors topic: not user facing topic category and removed ciflow/trunk Trigger trunk jobs on your pull request labels Dec 20, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed

Reason: 1 STARTUP failures reported, please check workflows syntax! trunk

Details for Dev Infra team Raised by workflow job

@Skylion007
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 20, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@albanD albanD removed their request for review December 20, 2023 20:02
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
…ytorch#116192)

Removes an unnecessary duplicated utility functions and just have it rely on itertools. Since the file is low traffic, I also added the modified files to UFMT'd files and formatted them.
Pull Request resolved: pytorch#116192
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: dataloader release notes category topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants