Skip to content

[ROCm] fix nightly 5.6 build#116029

Closed
jeffdaily wants to merge 1 commit intopytorch:mainfrom
ROCm:rocm_fix_nightly_56_build
Closed

[ROCm] fix nightly 5.6 build#116029
jeffdaily wants to merge 1 commit intopytorch:mainfrom
ROCm:rocm_fix_nightly_56_build

Conversation

@jeffdaily
Copy link
Copy Markdown
Collaborator

@jeffdaily jeffdaily commented Dec 18, 2023 •
edited by pytorch-bot bot
Loading

ROCm 5.6 nightly wheel build broken by #114329. This fixes it.

cc @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

@pytorch-bot pytorch-bot bot added the ciflow/rocm Trigger "default" config CI on ROCm label Dec 18, 2023
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Dec 18, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116029

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (9 Unrelated Failures)

As of commit e688d95 with merge base 1d5a9a1 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the module: rocm AMD GPU support for Pytorch label Dec 18, 2023
@jeffdaily
Copy link
Copy Markdown
Collaborator Author

jeffdaily commented Dec 18, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 18, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Dec 18, 2023

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@jeffdaily jeffdaily added the topic: not user facing topic category label Dec 18, 2023
@jeffdaily
Copy link
Copy Markdown
Collaborator Author

jeffdaily commented Dec 18, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Dec 18, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jeanschmidt
Copy link
Copy Markdown
Contributor

jeanschmidt commented Dec 19, 2023

@pytorchbot revert -m "Need to revert, in order to be able to revert #114329" -c ghfirst

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Dec 19, 2023

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Dec 19, 2023

@jeffdaily your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Dec 19, 2023
@pytorchmergebot
Revert "[ROCm] fix nightly 5.6 build (#116029)"
ed0c0c4 
This reverts commit 63e242b.

Reverted #116029 on behalf of https://github.com/jeanschmidt due to Need to revert, in order to be able to revert #114329 ([comment](#116029 (comment)))
@jeffdaily
Copy link
Copy Markdown
Collaborator Author

jeffdaily commented Dec 20, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Dec 20, 2023

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Dec 20, 2023

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/7280554829

@jeffdaily jeffdaily force-pushed the rocm_fix_nightly_56_build branch from 7b70826 to e688d95 Compare December 20, 2023 21:02
@jeffdaily
Copy link
Copy Markdown
Collaborator Author

jeffdaily commented Dec 20, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Dec 20, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Dec 20, 2023

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@jeffdaily
Copy link
Copy Markdown
Collaborator Author

jeffdaily commented Dec 21, 2023

@pytorchbot merge -f "unrelated unstable tests failing; rocm CI passing"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Dec 21, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kit1980 kit1980 removed the Reverted label Dec 21, 2023
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@jeffdaily @dmenig
[ROCm] fix nightly 5.6 build (pytorch#116029)
8e59208 
ROCm 5.6 nightly wheel build broken by pytorch#114329.  This fixes it.

Pull Request resolved: pytorch#116029
Approved by: https://github.com/huydhn, https://github.com/jithunnair-amd, https://github.com/atalman
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@pytorchmergebot @dmenig
Revert "[ROCm] fix nightly 5.6 build (pytorch#116029)"
c2cc5e0 
This reverts commit 63e242b.

Reverted pytorch#116029 on behalf of https://github.com/jeanschmidt due to Need to revert, in order to be able to revert pytorch#114329 ([comment](pytorch#116029 (comment)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@atalman atalman atalman approved these changes

@jithunnair-amd jithunnair-amd jithunnair-amd approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jeffdaily @pytorchmergebot @jeanschmidt @huydhn @atalman @jithunnair-amd @kit1980 @pytorchbot