Closed
Conversation
Summary: hipblasLt is much better in performance than hipblas, so try to use it in more cases. Differential Revision: D51695327
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114890
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit d0bb1fa with merge base b35ca2c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51695327 |
Contributor
This PR needs a
|
pytorchmergebot
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Dec 1, 2023
Collaborator
|
This change is merged to #114329. |
pytorchmergebot
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Dec 14, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 10, 2024
This PR fixes the accuracy issues for hipblasLT for mm case on ROCm. This PR is a follow up to the integration PR #114329 and #114890 The accuracy issue arises for mm usecase for ROCm where hipblasLT is enabled, and a bias has been passed which is not required. This PR addresses that issue. Added a unit-test case for this issue (bias=None) case. Pull Request resolved: #116537 Approved by: https://github.com/jeffdaily, https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: hipblasLt is much better in performance than hipblas, so try to use it in more cases.
Differential Revision: D51695327