[Caffe2] Search for CMake config files for pybind11.#11423
Closed
xkszltl wants to merge 1 commit intopytorch:masterfrom
Closed
[Caffe2] Search for CMake config files for pybind11.#11423xkszltl wants to merge 1 commit intopytorch:masterfrom
xkszltl wants to merge 1 commit intopytorch:masterfrom
Conversation
ezyang
reviewed
Sep 9, 2018
|
|
||
| if(pybind11_FOUND) | ||
| include_directories(SYSTEM ${pybind11_INCLUDE_DIRS}) | ||
| include_directories(SYSTEM ${pybind11_INCLUDE_DIRS}) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Sep 9, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 9, 2018
Summary: If pybind is build with cmake and installed, we should use config file instead of the Findpybind11 shipped with caffe2. Pull Request resolved: pytorch/pytorch#11423 Differential Revision: D9735557 Pulled By: ezyang fbshipit-source-id: 28a39e579fa045060aa1a716e5fd7dbcf7b89569
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: If pybind is build with cmake and installed, we should use config file instead of the Findpybind11 shipped with caffe2. Pull Request resolved: pytorch#11423 Differential Revision: D9735557 Pulled By: ezyang fbshipit-source-id: 28a39e579fa045060aa1a716e5fd7dbcf7b89569
Baranowski
added a commit
to Quansight/pytorch
that referenced
this pull request
May 5, 2020
…IG); find_package(...) (Revert 538ea67, pytorch#11423) The latter variant erases cached value when nothing is found in the CONFIG mode
Baranowski
added a commit
to Quansight/pytorch
that referenced
this pull request
May 5, 2020
…... CONFIG); find_package(...) (Revert 538ea67, pytorch#11423)" This reverts commit c109a19317f1c876d9494e0529c872f34c273427.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If pybind is build with cmake and installed, we should use config file instead of the Findpybind11 shipped with caffe2.