Enable build_python on windows by mingzhe09088 · Pull Request #11385 · pytorch/pytorch

mingzhe09088 · 2018-09-07T17:06:20Z

The PR aims to resolve issues related to BUILD_PYTHON and BUILD_TEST after FULL_CAFFE2 is removed on Windows.

peterjc123 · 2018-09-11T02:49:43Z

These are the symbols that are not well annotated extracted from the build log.

error LNK2019: unresolved external symbol "__declspec(dllimport) public: char const * __cdecl caffe2::Registry<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<class caffe2::OperatorBase,struct std::default_delete<class caffe2::OperatorBase> >,class caffe2::OperatorDef const &,class caffe2::Workspace *>::HelpMessage(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)const "  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl caffe2::Registry<class caffe2::TypeIdentifier,class std::unique_ptr<class caffe2::python::BlobFetcherBase,struct std::default_delete<class caffe2::python::BlobFetcherBase> > >::Registry<class caffe2::TypeIdentifier,class std::unique_ptr<class caffe2::python::BlobFetcherBase,struct std::default_delete<class caffe2::python::BlobFetcherBase> > >(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::unique_ptr<class caffe2::python::BlobFetcherBase,struct std::default_delete<class caffe2::python::BlobFetcherBase> > __cdecl caffe2::Registry<class caffe2::TypeIdentifier,class std::unique_ptr<class caffe2::python::BlobFetcherBase,struct std::default_delete<class caffe2::python::BlobFetcherBase> > >::Create(class caffe2::TypeIdentifier const &)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl caffe2::Registry<enum at::DeviceType,class std::unique_ptr<class caffe2::python::BlobFeederBase,struct std::default_delete<class caffe2::python::BlobFeederBase> > >::Registry<enum at::DeviceType,class std::unique_ptr<class caffe2::python::BlobFeederBase,struct std::default_delete<class caffe2::python::BlobFeederBase> > >(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::unique_ptr<class caffe2::python::BlobFeederBase,struct std::default_delete<class caffe2::python::BlobFeederBase> > __cdecl caffe2::Registry<enum at::DeviceType,class std::unique_ptr<class caffe2::python::BlobFeederBase,struct std::default_delete<class caffe2::python::BlobFeederBase> > >::Create(enum at::DeviceType const &)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::vector<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::allocator<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > > __cdecl caffe2::Registry<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<class caffe2::db::DB,struct std::default_delete<class caffe2::db::DB> >,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,enum caffe2::db::Mode>::Keys(void)"  
error LNK2019: unresolved external symbol "public: __cdecl onnx_torch::ValueInfoProto::ValueInfoProto(void)"  
error LNK2019: unresolved external symbol "public: virtual __cdecl onnx_torch::ValueInfoProto::~ValueInfoProto(void)"  
error LNK2019: unresolved external symbol "private: void __cdecl onnx_torch::ValueInfoProto::InternalSwap(class onnx_torch::ValueInfoProto *)"  
error LNK2019: unresolved external symbol "public: __cdecl onnx_torch::TensorProto::TensorProto(void)"  
error LNK2019: unresolved external symbol "public: virtual __cdecl onnx_torch::TensorProto::~TensorProto(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl caffe2::Registerer<class caffe2::TypeIdentifier,class std::unique_ptr<class caffe2::python::BlobFetcherBase,struct std::default_delete<class caffe2::python::BlobFetcherBase> > >::Registerer<class caffe2::TypeIdentifier,class std::unique_ptr<class caffe2::python::BlobFetcherBase,struct std::default_delete<class caffe2::python::BlobFetcherBase> > >(class caffe2::TypeIdentifier const &,class caffe2::Registry<class caffe2::TypeIdentifier,class std::unique_ptr<class caffe2::python::BlobFetcherBase,struct std::default_delete<class caffe2::python::BlobFetcherBase> > > *,class std::function<class std::unique_ptr<class caffe2::python::BlobFetcherBase,struct std::default_delete<class caffe2::python::BlobFetcherBase> > __cdecl(void)>,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl caffe2::Registerer<enum at::DeviceType,class std::unique_ptr<class caffe2::python::BlobFeederBase,struct std::default_delete<class caffe2::python::BlobFeederBase> > >::Registerer<enum at::DeviceType,class std::unique_ptr<class caffe2::python::BlobFeederBase,struct std::default_delete<class caffe2::python::BlobFeederBase> > >(enum at::DeviceType const &,class caffe2::Registry<enum at::DeviceType,class std::unique_ptr<class caffe2::python::BlobFeederBase,struct std::default_delete<class caffe2::python::BlobFeederBase> > > *,class std::function<class std::unique_ptr<class caffe2::python::BlobFeederBase,struct std::default_delete<class caffe2::python::BlobFeederBase> > __cdecl(void)>,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: bool __cdecl caffe2::Registry<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<class caffe2::GradientMakerBase,struct std::default_delete<class caffe2::GradientMakerBase> >,class caffe2::OperatorDef const &,class std::vector<struct caffe2::GradientWrapper,class std::allocator<struct caffe2::GradientWrapper> > const &>::Has(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: char const * __cdecl caffe2::Registry<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<class caffe2::GradientMakerBase,struct std::default_delete<class caffe2::GradientMakerBase> >,class caffe2::OperatorDef const &,class std::vector<struct caffe2::GradientWrapper,class std::allocator<struct caffe2::GradientWrapper> > const &>::HelpMessage(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)const "  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: bool __cdecl caffe2::Registry<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<class caffe2::OptimizationPass,struct std::default_delete<class caffe2::OptimizationPass> >,struct nom::repr::NNModule *>::Has(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::unique_ptr<class caffe2::OptimizationPass,struct std::default_delete<class caffe2::OptimizationPass> > __cdecl caffe2::Registry<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<class caffe2::OptimizationPass,struct std::default_delete<class caffe2::OptimizationPass> >,struct nom::repr::NNModule *>::Create(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,struct nom::repr::NNModule *)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: bool __cdecl caffe2::Registry<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<class caffe2::WorkspaceOptimizationPass,struct std::default_delete<class caffe2::WorkspaceOptimizationPass> >,struct nom::repr::NNModule *,class caffe2::Workspace *>::Has(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::unique_ptr<class caffe2::WorkspaceOptimizationPass,struct std::default_delete<class caffe2::WorkspaceOptimizationPass> > __cdecl caffe2::Registry<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<class caffe2::WorkspaceOptimizationPass,struct std::default_delete<class caffe2::WorkspaceOptimizationPass> >,struct nom::repr::NNModule *,class caffe2::Workspace *>::Create(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,struct nom::repr::NNModule *,class caffe2::Workspace *)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::unique_ptr<struct caffe2::python::PybindAddition,struct std::default_delete<struct caffe2::python::PybindAddition> > __cdecl caffe2::Registry<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<struct caffe2::python::PybindAddition,struct std::default_delete<struct caffe2::python::PybindAddition> >,class pybind11::module &>::Create(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class pybind11::module &)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::vector<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::allocator<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > > __cdecl caffe2::Registry<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<struct caffe2::python::PybindAddition,struct std::default_delete<struct caffe2::python::PybindAddition> >,class pybind11::module &>::Keys(void)"  
error LNK2019: unresolved external symbol "const onnx_torch::ValueInfoProto::`vftable'"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Graph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::Graph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Graph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::~Graph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::vector<class nom::Node<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> > *,class std::allocator<class nom::Node<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> > *> > const __cdecl nom::Graph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::getMutableNodes(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::vector<class nom::Edge<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> > *,class std::allocator<class nom::Edge<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> > *> > const __cdecl nom::Graph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::getMutableEdges(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Graph<class pybind11::object>::Graph<class pybind11::object>(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Graph<class pybind11::object>::~Graph<class pybind11::object>(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class nom::Node<class pybind11::object> * __cdecl nom::Graph<class pybind11::object>::createNode(class pybind11::object &&)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class nom::Edge<class pybind11::object> * __cdecl nom::Graph<class pybind11::object>::createEdge(class nom::Node<class pybind11::object> *,class nom::Node<class pybind11::object> *)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::vector<class nom::Node<class pybind11::object> *,class std::allocator<class nom::Node<class pybind11::object> *> > const __cdecl nom::Graph<class pybind11::object>::getMutableNodes(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Node<class pybind11::object>::Node<class pybind11::object>(class nom::Node<class pybind11::object> &&)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: virtual __cdecl nom::Node<class pybind11::object>::~Node<class pybind11::object>(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: struct nom::repr::nn::NNNodeMatchCriteria __cdecl nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria>::getCriteria(void)const "  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Subgraph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::Subgraph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: void __cdecl nom::Subgraph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::addNode(class nom::Node<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> > *)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Subgraph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::~Subgraph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Subgraph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::Subgraph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >(class nom::Subgraph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> > const &)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Subgraph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::Subgraph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >(class nom::Subgraph<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> > &&)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl caffe2::Registerer<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<struct caffe2::python::PybindAddition,struct std::default_delete<struct caffe2::python::PybindAddition> >,class pybind11::module &>::Registerer<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<struct caffe2::python::PybindAddition,struct std::default_delete<struct caffe2::python::PybindAddition> >,class pybind11::module &>(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class caffe2::Registry<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<struct caffe2::python::PybindAddition,struct std::default_delete<struct caffe2::python::PybindAddition> >,class pybind11::module &> *,class std::function<class std::unique_ptr<struct caffe2::python::PybindAddition,struct std::default_delete<struct caffe2::python::PybindAddition> > __cdecl(class pybind11::module &)>,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Graph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>::Graph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Graph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>::~Graph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class nom::Node<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper> * __cdecl nom::Graph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>::createNode(struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper &&)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class nom::Edge<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper> * __cdecl nom::Graph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>::createEdge(class nom::Node<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper> *,class nom::Node<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper> *,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::vector<class nom::Node<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper> *,class std::allocator<class nom::Node<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper> *> > const __cdecl nom::Graph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>::getMutableNodes(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Subgraph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>::Subgraph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: void __cdecl nom::Subgraph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>::addNode(class nom::Node<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper> *)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: void __cdecl nom::Subgraph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>::addEdge(class nom::Edge<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper> *)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Subgraph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>::~Subgraph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>(void)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl nom::Subgraph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>::Subgraph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper>(class nom::Subgraph<struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::NodeWrapper,struct nom::algorithm::GraphWrapper<class nom::matcher::MatchNode<struct nom::repr::nn::NNNodeMatchCriteria> >::EdgeWrapper> const &)"  
error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl caffe2::Registry<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<struct caffe2::python::PybindAddition,struct std::default_delete<struct caffe2::python::PybindAddition> >,class pybind11::module &>::Registry<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::unique_ptr<struct caffe2::python::PybindAddition,struct std::default_delete<struct caffe2::python::PybindAddition> >,class pybind11::module &>(void)"

ezyang · 2018-09-12T03:36:02Z

@pytorchbot retest this please

orionr · 2018-09-13T15:09:42Z

Waiting for #11622 to land and then I'll merge again

orionr · 2018-09-13T15:19:21Z

Actually - I take that back. Updating the submodule here.

houseroad · 2018-09-13T17:43:38Z

#11622 is landed :-)

peterjc123 · 2018-09-14T07:01:54Z

I have skimmed the log. There seems to be only some remaining, like const onnx_torch::ValueInfoProto::~vftable. I guess that we'll need to restructure some of the code, moving the implementation part to the source file. (something like the solution 4 in this post) As for the last linking failure, I think it is probably caused by previous linking errors.

caffe2/core/qtensor.h

facebook-github-bot

mingzhe09088 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

mingzhe09088 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: The PR aims to resolve issues related to BUILD_PYTHON and BUILD_TEST after FULL_CAFFE2 is removed on Windows. Pull Request resolved: pytorch/pytorch#11385 Reviewed By: orionr Differential Revision: D9884906 Pulled By: mingzhe09088 fbshipit-source-id: fc114c0cbff6223f1ec261161e4caecc1fef5dd6

mingzhe09088 requested review from apaszke, colesbury, ezyang, gchanan, soumith and zdevito as code owners September 7, 2018 17:06

pytorchbot added the caffe2 label Sep 7, 2018

orionr mentioned this pull request Sep 10, 2018

Fixes errors when linking caffe2 statically #10765

Closed

orionr mentioned this pull request Sep 11, 2018

Windows CI integration for custom ops #11527

Closed

mingzhe09088 changed the title ~~[WIP] Enable build_python on windows~~ [WIP] Enable build_python and build_test on windows Sep 12, 2018

This was referenced Sep 12, 2018

[WIP][build] Enable BUILD_TEST for Windows #11483

Closed

[build] Add ONNX_API for protos in all cases onnx/onnx#1407

Merged

peterjc123 reviewed Sep 14, 2018

View reviewed changes

caffe2/core/qtensor.h Outdated

This comment was marked as off-topic.

Sign in to view

orionr and others added 11 commits September 17, 2018 11:19

Remove FULL_CAFFE2 flag

269b787

Default USE_OPENCV to OFF and pass from setup.py

b7acc87

Temporarily disable non-ATen tests on Windows DLL

f2eff15

Disable Caffe2 python on Windows for now

8465431

Disable tests on Windows

c355799

Set USE_OPENCV=ON by default for CMake builds

3595e70

Enable build_python

2c2d05d

Skip string strip for windows

fb3c59d

test

2f46b87

Remove CAFFE2_API from registry

85ae4b0

Remove CAFFE2_API from Registerer

47c2007

mingzhe09088 and others added 15 commits September 17, 2018 11:19

Remove CAFFE2_API from nomigraph

1362d3d

Remove CAFFE2_API from subgraph

6a52124

Remove CAFFE2_API

4cd35e6

Remove CAFFE2_API

1b8b0ae

Enable BUILD_TEST for Windows

572ca3f

Fix for onnx

942db3d

Remove CAFFE2_API from qtensor

a9e639f

One more fix for ONNX with upstream change

32e4e02

More changes for ONNX refs once changes land upstream

4ac2505

Skip check of missing symbols on Windows

11392a7

Add CAFFE2_CUDA_API

74c9661

Add more CAFFE2_CUDA_API

3c17a6a

Fix

972cdab

Disable build_test

04ed253

Add CAFFE2_API for QTensor

dc7aaf1

mingzhe09088 changed the title ~~[WIP] Enable build_python and build_test on windows~~ Enable build_python on windows Sep 17, 2018

facebook-github-bot reviewed Sep 17, 2018

View reviewed changes

Only export ONNX symbols on DLL for Windows

c2ac6db

facebook-github-bot reviewed Sep 18, 2018

View reviewed changes

facebook-github-bot closed this in a7cbcb1 Sep 18, 2018

ezyang added the merged label Jun 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable build_python on windows#11385

Enable build_python on windows#11385
mingzhe09088 wants to merge 27 commits intopytorch:masterfrom
mingzhe09088:windows-python

mingzhe09088 commented Sep 7, 2018 •

edited by orionr

Loading

Uh oh!

peterjc123 commented Sep 11, 2018

Uh oh!

ezyang commented Sep 12, 2018

Uh oh!

orionr commented Sep 13, 2018

Uh oh!

orionr commented Sep 13, 2018

Uh oh!

houseroad commented Sep 13, 2018

Uh oh!

peterjc123 commented Sep 14, 2018 •

edited

Loading

Uh oh!

This comment was marked as off-topic.

Uh oh!

facebook-github-bot left a comment

Uh oh!

facebook-github-bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

mingzhe09088 commented Sep 7, 2018 • edited by orionr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peterjc123 commented Sep 11, 2018

Uh oh!

ezyang commented Sep 12, 2018

Uh oh!

orionr commented Sep 13, 2018

Uh oh!

orionr commented Sep 13, 2018

Uh oh!

houseroad commented Sep 13, 2018

Uh oh!

peterjc123 commented Sep 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as off-topic.

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mingzhe09088 commented Sep 7, 2018 •

edited by orionr

Loading

peterjc123 commented Sep 14, 2018 •

edited

Loading