Add option to use CUDA memory leak testing as a context manager#11380
Closed
zou3519 wants to merge 2 commits intopytorch:masterfrom
Closed
Add option to use CUDA memory leak testing as a context manager#11380zou3519 wants to merge 2 commits intopytorch:masterfrom
zou3519 wants to merge 2 commits intopytorch:masterfrom
Conversation
13ed2ec to
187309d
Compare
ssnl
approved these changes
Sep 7, 2018
Collaborator
ssnl
left a comment
There was a problem hiding this comment.
LGTM! Have one minor suggestion.
| from common_cuda import initialize_cuda_context_rng | ||
| initialize_cuda_context_rng() | ||
|
|
||
| def __enter__(self): |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
Tests look OK; I'm ignoring the CircleCi tests. |
apaszke
approved these changes
Sep 10, 2018
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
…rch#11380) Summary: cc SsnL Pull Request resolved: pytorch#11380 Reviewed By: ezyang Differential Revision: D9705877 Pulled By: zou3519 fbshipit-source-id: 02470c25236f57fa02f4ac9d7ed63d38a6355db2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @ssnl