Remove symbol export annotations in THC/generic/*.cu#11367
Remove symbol export annotations in THC/generic/*.cu#11367peterjc123 wants to merge 6 commits intopytorch:masterfrom
Conversation
facebook-github-bot
left a comment
There was a problem hiding this comment.
Yangqing has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@peterjc123 since THC_API also includes the THC_EXTERN (aka extern "C") - maybe we need to change it to THC_EXTERN instead of removing it? |
|
@Yangqing Sorry, I don't quite get the reasons to change them to |
|
The missing of the export symbols |
|
Ah makes sense, I'll leave the symbol issues for the original TH authors to deal with then... |
|
@peterjc123 probably need a rebase |
6b80086 to
a54f9ba
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: We use these annotations during function declarations, not definitions. See the description of compiler error [C2491](https://msdn.microsoft.com/en-us/library/62688esh.aspx) for more details. Pull Request resolved: pytorch/pytorch#11367 Reviewed By: ezyang Differential Revision: D9697923 Pulled By: orionr fbshipit-source-id: 1e539c02957851386f887e6d0510ce83117a1695
We use these annotations during function declarations, not definitions. See the description of compiler error C2491 for more details.